Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(auth): report sessionDuration on reauth aws_loginWithBrowser #6013

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

nkomonen-amazon
Copy link
Contributor

Depends on aws/aws-toolkit-common#914

Problem

On the condition of:

  • SSO session is BuilderID or Internal Amazon IdC
  • Subsequent login for same SSO session happened earlier than 90 days (the expected session expiration)

We need to know on the client side to be able to report this information so that CloudWatch alarms can consume this.

Solution

By adding the existing sessionDuration field, which is currentTime - whenThePreviousSessionWasCreated, to aws_loginWithBrowser we will have all the information we need to alarm on.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nkomonen-amazon nkomonen-amazon requested a review from a team as a code owner November 14, 2024 04:34
@nkomonen-amazon nkomonen-amazon changed the title Login with browser feat(telemetry): report sessionDuration on reauth aws_loginWithBrowser Nov 14, 2024
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@nkomonen-amazon nkomonen-amazon changed the title feat(telemetry): report sessionDuration on reauth aws_loginWithBrowser telemetry(auth): report sessionDuration on reauth aws_loginWithBrowser Nov 14, 2024
Signed-off-by: nkomonen-amazon <[email protected]>
Signed-off-by: nkomonen-amazon <[email protected]>
@nkomonen-amazon nkomonen-amazon merged commit 384d287 into aws:master Nov 14, 2024
23 of 25 checks passed
@nkomonen-amazon nkomonen-amazon deleted the loginWithBrowser branch November 14, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants