auth: add sessionDuration to aws_loginWithBrowser
#914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to know about the previous sessionDuration, if there is one, the next time we log in to the same SSO session due to something like expiration. We will use this in CloudWatch to alarm on if we are seeing a scenario like BuilderID emitting another `aws_loginWithBrowser` less than 90 days after the previous `aws_loginWithBrowser`. Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
sessionDurationLoginWithBrowser
branch
from
c1e4291 to
a5c435e
Compare
jpinkney-aws
approved these changes
Nov 14, 2024
nkomonen-amazon
added a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Nov 14, 2024
…er` (#6013) Depends on aws/aws-toolkit-common#914 ## Problem On the condition of: - SSO session is BuilderID or Internal Amazon IdC - Subsequent login for same SSO session happened earlier than 90 days (the expected session expiration) We need to know on the client side to be able to report this information so that CloudWatch alarms can consume this. ## Solution By adding the existing sessionDuration field, which is `currentTime - whenThePreviousSessionWasCreated`, to `aws_loginWithBrowser` we will have all the information we need to alarm on. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: nkomonen-amazon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to know about the previous sessionDuration, if there is one, the next time we log in to the same SSO session due to something like expiration.
We will use this in CloudWatch to alarm on if we are seeing a scenario like BuilderID emitting another
aws_loginWithBrowserless than 90 days after the previousaws_loginWithBrowser.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.