Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): remove deprecated s3 customization #6005

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Apr 15, 2024

Issue

1

The "s3-hack" was a customization that applied model preprocessing during the build of the S3 client.
It formerly did two things:

  • apply RuleSetAuthSchemes Smithy suppression that was missing from the model
  • apply the s3 expiresString customization to the model

The former is now included in the model itself, and the latter has been converted to Java codegen in #5963.

2

The runtime-dependency-version-check/runtime-dep-version-check has also been moved to the end of the code generation script. This ensures unexpected code generation output that is inconsistent with the repository state is blocked from releasing.

@kuhe kuhe requested a review from a team as a code owner April 15, 2024 20:06
@kuhe kuhe merged commit aaee685 into aws:main Apr 15, 2024
5 checks passed
@kuhe kuhe deleted the chore/validation branch April 15, 2024 20:29
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants