chore(codegen): remove deprecated s3 customization (#6005)

aws · Apr 15, 2024 · aaee685 · aaee685
1 parent 7142227
commit aaee685
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 49 deletions.
diff --git a/scripts/generate-clients/index.js b/scripts/generate-clients/index.js
@@ -16,7 +16,6 @@ const { prettifyCode } = require("./code-prettify");
 const { eslintFixCode } = require("./code-eslint-fix");
 const { buildSmithyTypeScript } = require("./build-smithy-typescript");
 const { SMITHY_TS_COMMIT } = require("./config");
-const s3Hack = require("./s3-hack");
 
 const SMITHY_TS_DIR = path.normalize(path.join(__dirname, "..", "..", "..", "smithy-typescript"));
 const SDK_CLIENTS_DIR = path.normalize(path.join(__dirname, "..", "..", "clients"));
@@ -77,7 +76,6 @@ const {
 
 (async () => {
   try {
-    require("../runtime-dependency-version-check/runtime-dep-version-check");
     if (!noSmithyCheckout) {
       await buildSmithyTypeScript(repo, commit);
     }
@@ -97,14 +95,7 @@ const {
     }
 
     if (!protocolTestsOnly) {
-      const undoS3 = s3Hack();
-      try {
-        await generateClients(models || globs || DEFAULT_CODE_GEN_INPUT_DIR, batchSize);
-        undoS3();
-      } catch (e) {
-        undoS3();
-        throw e;
-      }
+      await generateClients(models || globs || DEFAULT_CODE_GEN_INPUT_DIR, batchSize);
     }
 
     if (!noPrivateClients) {
@@ -148,6 +139,7 @@ const {
     }
 
     require("./customizations/workspaces-thin-client")();
+    require("../runtime-dependency-version-check/runtime-dep-version-check");
   } catch (e) {
     console.log(e);
     process.exit(1);

diff --git a/scripts/generate-clients/s3-hack.js b/scripts/generate-clients/s3-hack.js
diff --git a/scripts/generate-clients/single-service.js b/scripts/generate-clients/single-service.js
@@ -4,7 +4,6 @@ const { generateClient } = require("./code-gen");
 const { codeOrdering } = require("./code-ordering");
 const { copyToClients } = require("./copy-to-clients");
 const { spawnProcess } = require("../utils/spawn-process");
-const s3Hack = require("./s3-hack");
 
 const SDK_CLIENTS_DIR = normalize(join(__dirname, "..", "..", "clients"));
 
@@ -15,14 +14,7 @@ const { solo } = yargs(process.argv.slice(2))
 
 (async () => {
   try {
-    let afterGenerate = () => {};
-    if (solo === "s3") {
-      afterGenerate = s3Hack();
-    }
     await generateClient(solo);
-    if (solo === "s3") {
-      afterGenerate();
-    }
     await copyToClients(
       normalize(join(__dirname, "..", "..", "codegen", "sdk-codegen", "build-single", solo)),
       SDK_CLIENTS_DIR,