fix(lib-storage): URI-decoding of object Locations for Multipart Upload #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Jan 11, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
for multipart upload (for files > 5mb) the
CompleteMultipartUploadCommandreturns the Location of the file with%2fsymbol which is encoded/slash.Description
After migrating aws-sdk from v2 to v3 we've noticed that for large files (> 5mb) the final S3 url contains
%2finstead of/(it broke our frontend app, clients lost and access to such files).i've found out this issue was discussed
and fixed in
aws-sdk-js-v2issue #1158 and PR #1420and same for
aws-sdk-goissue #1385 and PR #2453