Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP5]chore(deps): enable yarn berry 3 with pnpm #3544

Closed
wants to merge 9 commits into from

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Follow-up to #3536

Description

WIP PR to test whether the CI can handle the PNPM


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner April 14, 2022 18:20
@AllanZhengYP AllanZhengYP marked this pull request as draft April 14, 2022 18:20
@AllanZhengYP
Copy link
Contributor Author

The unit test failed by

[Container] 2022/04/14 18:41:05 Running command yarn test:all
lerna notice cli v3.22.1
lerna info ci enabled
lerna ERR! Error: Unsupported URL Type "workspace:": workspace:*

Related to lerna/lerna#2564 and this change

@AllanZhengYP
Copy link
Contributor Author

Got another error:

lerna info Executing command in 1 package: "yarn run build"
lerna ERR! yarn run build exited 1 in '@aws-sdk/client-apigatewayv2'
lerna ERR! yarn run build stdout:
[build:types] src/runtimeConfig.browser.ts(21,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] src/runtimeConfig.native.ts(9,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] src/runtimeConfig.ts(32,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] yarn run build:types exited with code 1
[build:cjs] yarn run build:cjs exited with code 0
[build:es] yarn run build:es exited with code 0

It's discussed in microsoft/TypeScript#42873 but none of the solution works here

@AllanZhengYP
Copy link
Contributor Author

Got the CI mostly work but I found it doesn't quite compatible with our StepFunction + CodeBuild CD pipeline. The zipping & unzipping of the the workspace seems to break the hard links created by the PNPM linker, here's the node_modules after unzipping:

ls -al packages/abort-controller/node_modules
total 0
drwxr-xr-x@ 10 zheallan  staff  320 Apr 15 00:44 .
drwxr-xr-x@ 13 zheallan  staff  416 Apr 15 00:44 ..
drwxr-xr-x@  3 zheallan  staff   96 Apr 15 00:44 @aws-sdk
drwxr-xr-x@  3 zheallan  staff   96 Apr 15 00:44 @tsconfig

ls: packages/abort-controller/node_modules/concurrently: Permission denied
l---------   1 zheallan  staff   88 Apr 15 00:44 concurrently

ls: packages/abort-controller/node_modules/downlevel-dts: Permission denied
l---------   1 zheallan  staff   90 Apr 15 00:44 downlevel-dts

ls: packages/abort-controller/node_modules/rimraf: Permission denied
l---------   1 zheallan  staff   76 Apr 15 00:44 rimraf

ls: packages/abort-controller/node_modules/tslib: Permission denied
l---------   1 zheallan  staff   74 Apr 15 00:44 tslib

ls: packages/abort-controller/node_modules/typedoc: Permission denied
l---------   1 zheallan  staff   76 Apr 15 00:44 typedoc

ls: packages/abort-controller/node_modules/typescript: Permission denied
l---------   1 zheallan  staff   80 Apr 15 00:44 typescript

@AllanZhengYP
Copy link
Contributor Author

I've confirmed the hardlinks created by pnpm linker are broken by the zip of CodeBuild. I'm out of idea... I will do more research for anyone have done that.

@trivikr trivikr closed this Aug 31, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants