Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP4] chore(deps-dev): migrate to yarn berry 3 with pnp #3536

Closed
wants to merge 24 commits into from

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Apr 13, 2022

Issue

Replaces #3494

Description

The #3494 change causes the link stage to hang because yarn takes forever to create node_modules. This attempt uses P'N'P to eliminate the time spent to create node_modules.

Testing

The update needs to gurantee all the scripts below to pass:

  • bootstrap
  • bootstrap:ci
  • build:all
  • build:clients:generic
  • build:clients:since:release
  • build:crypto-dependencies
  • build:docs
  • build:e2e
  • build:packages
  • build:protocols
  • build:server-protocols
  • build:types:downlevel
  • clean & clean-*
  • copy-models
  • generate-clients & generate:clients:generic
  • generate:defaults-mode-provider
  • lerna:version
  • local-publish
  • test:all
  • test:e2e
  • test:functional
  • test:integration
  • test:integration:legacy
  • test:integration:legacy:since:release
  • test:protocols
  • test:server-protocols
  • test:size
  • test:unit
  • test:versions
  • update:versions:default
  • update:versions:current

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP
Copy link
Contributor Author

AllanZhengYP commented Apr 13, 2022

It seems like the jest unit test hangs too.

I started another same build & test locally and it hangs for 26mins already -- at a different test case.

S  ...dential-provider-cognito-identity/src/fromCognitoIdentity.spec.ts
 RUNS  packages/body-checksum-browser/src/index.spec.ts
 RUNS  packages/config-resolver/src/regionInfo/getRegionInfo.spec.ts
 RUNS  ...dpoint/src/NodeDisableMultiregionAccessPointConfigOptions.spec.ts
 RUNS  lib/lib-storage/src/chunks/getChunkBuffer.spec.ts
 RUNS  packages/eventstream-marshaller/src/Int64.spec.ts
 RUNS  lib/lib-storage/src/chunks/getDataReadableStream.spec.ts
 RUNS  lib/lib-dynamodb/src/commands/utils.spec.ts
 RUNS  ...s/middleware-bucket-endpoint/src/bucketEndpointMiddleware.spec.ts
 RUNS  packages/credential-providers/src/fromTemporaryCredentials.spec.ts
 RUNS  packages/abort-controller/src/AbortController.spec.ts
 RUNS  packages/shared-ini-file-loader/src/parseKnownFiles.spec.ts

Test Suites: 2 skipped, 209 passed, 209 of 262 total
Tests:       14 skipped,
Snapshots:   0 total
Time:        1735 s

@AllanZhengYP AllanZhengYP changed the title [WIP4] chore(deps-dev): migrage to yarn berry 3 with pnp [WIP4] chore(deps-dev): migrate to yarn berry 3 with pnp Apr 13, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants