Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP2] chore(deps-dev): yarn set version berry #3252

Closed
wants to merge 7 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 25, 2022

Issue

Refs: #3182 (comment)
Reasons to bump to yarn modern https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern

The experimental projects in aws-samples repo have been using yarn berry for some time now:

Description

Updates yarn version to berry.

Testing

ToDo: verify commands used in release scripts are successful.

Additional Context

Cleaned up PR of original attempt at #3235


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Jan 26, 2022

The existing error is likely related to customizations in client-sts

lerna ERR! yarn run build exited 1 in '@aws-sdk/client-sts'
lerna ERR! yarn run build stdout:
[build:cjs] yarn run build:cjs exited with code 0
[build:es] yarn run build:es exited with code 0
[build:types] src/runtimeConfig.browser.ts(21,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] src/runtimeConfig.native.ts(9,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] src/runtimeConfig.ts(32,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] yarn run build:types exited with code 1

lerna ERR! yarn run build exited 1 in '@aws-sdk/client-sts'

In this PR, we reintroduced star dependency for client-sts in karma-credential-loader as yarn install is successful with berry
66e6776 (#3252)
Also, yarn berry used to update lockfile with every run in WIP1 PR at #3235 because of file import of client-sts

@trivikr
Copy link
Member Author

trivikr commented Mar 29, 2022

Superceded by #3494

@trivikr trivikr closed this Mar 29, 2022
@trivikr trivikr deleted the yarn-berry-2 branch March 29, 2022 23:35
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant