Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP1] chore(deps-dev): yarn set version berry #3235

Closed
wants to merge 13 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 24, 2022

Issue

Refs: #3182 (comment)
Reasons to bump to yarn modern https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern

The experimental projects in aws-samples repo have been using yarn berry for some time now:

Description

Updates yarn version to berry.

Testing

ToDo: verify commands used in release scripts are successful.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Jan 24, 2022

Work is paused at the following failure in some clients:

lerna info run Ran npm script 'build' in '@aws-sdk/client-finspace-data' in 33.4s:
[build:types] yarn run build:types exited with code 0
[build:cjs] yarn run build:cjs exited with code 0
[build:es] yarn run build:es exited with code 0
lerna info run Ran npm script 'build' in '@aws-sdk/client-elasticache' in 38.7s:
[build:types] yarn run build:types exited with code 0
[build:cjs] yarn run build:cjs exited with code 0
[build:es] yarn run build:es exited with code 0
lerna ERR! yarn run build exited 1 in '@aws-sdk/client-finspace'
lerna ERR! yarn run build stdout:
[build:cjs] yarn run build:cjs exited with code 0
[build:es] yarn run build:es exited with code 0
[build:types] src/runtimeConfig.browser.ts(21,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] src/runtimeConfig.native.ts(9,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middleware-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] src/runtimeConfig.ts(32,14): error TS2742: The inferred type of 'getRuntimeConfig' cannot be named without a reference to '../../../packages/middlew
are-signing/node_modules/@aws-sdk/signature-v4/dist-types'. This is likely not portable. A type annotation is necessary.
[build:types] yarn run build:types exited with code 1

@trivikr
Copy link
Member Author

trivikr commented Jan 25, 2022

Error:

[Container] 2022/01/25 03:32:27 Running command yarn test:all
FAIL private/aws-protocoltests-json-10/test/functional/awsjson1_0.spec.ts
  ● Test suite failed to run

    �[96mprivate/aws-protocoltests-json-10/test/functional/awsjson1_0.spec.ts�[0m:�[93m1�[0m:�[93m56�[0m - �[91merror�[0m�[90m TS2307: �[0mCannot find module '@aws-sdk/protocol-http' or its corresponding type declarations.

    �[7m1�[0m import { HttpHandler, HttpRequest, HttpResponse } from "@aws-sdk/protocol-http";

It looks like pretest:all script is not run by yarn berry.
This happens as pre and post scripts are deliberately deprecated as explained in yarnpkg/berry#995 (comment)

@trivikr trivikr changed the title chore(deps-dev): yarn set version berry [WIP1] chore(deps-dev): yarn set version berry Jan 25, 2022
@trivikr
Copy link
Member Author

trivikr commented Jan 25, 2022

Superceded by #3252

@trivikr trivikr closed this Jan 25, 2022
@trivikr trivikr deleted the yarn-berry branch January 25, 2022 21:22
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant