Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI didn't fail for missing dependency of client-s3-control #738

Closed
trivikr opened this issue Jan 15, 2020 · 3 comments
Closed

CI didn't fail for missing dependency of client-s3-control #738

trivikr opened this issue Jan 15, 2020 · 3 comments
Labels
CI/CD This is related to CI/CD High Priority

Comments

@trivikr
Copy link
Member

trivikr commented Jan 15, 2020

Describe the bug
CI didn't fail for missing dependency of client-s3-control

To Reproduce (observed behavior)

Expected behavior
CI should fail if dependency is missing
@trivikr trivikr added the bug This issue is a bug. label Jan 15, 2020
@AllanZhengYP AllanZhengYP added CI/CD This is related to CI/CD and removed bug This issue is a bug. labels Mar 6, 2020
@AllanZhengYP AllanZhengYP mentioned this issue Jun 1, 2020
Merged
AllanZhengYP added a commit that referenced this issue Jun 1, 2020
@AllanZhengYP
chore: yarn nohoist in codebuild ci
5679e64 
Fixes #738
@AllanZhengYP AllanZhengYP mentioned this issue Jun 1, 2020
Closed
@alexforsyth
Copy link
Contributor

#817

@AllanZhengYP
Copy link
Contributor

Close this because of duplication. We will provide more updates on #817 .

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CI/CD This is related to CI/CD High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: yarn nohoist in codebuild ci aws/aws-sdk-js-v3
3 participants
@AllanZhengYP @alexforsyth @trivikr