Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't fail if dependency is not present in client, but present in other clients #817

Closed
trivikr opened this issue Jan 29, 2020 · 3 comments
Assignees
Labels

Comments

@trivikr
Copy link
Member

trivikr commented Jan 29, 2020

Describe the bug
CI doesn't fail if dependency is not present in client, but present in other clients

To Reproduce (observed behavior)
Noticed in #815

Behavior:

Expected behavior
CI should fail if dependencies aren't added, otherwise they will block release as in #798

@trivikr
Copy link
Member Author

trivikr commented Feb 4, 2020

Similar lack of dependency issue was caught in release scripts, and needed to be fixed in #839

@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Nov 24, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants