Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit iso8601 fractional second precision to milliseconds #3507

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Limit iso8601 fractional second precision to milliseconds #3507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2e6b7c
Limit iso8601 fractional second precision to milliseconds
skmcgrail Aug 26, 2020
34c4027
Add CHANGELOG_PENDING.md and correct typo
skmcgrail Aug 26, 2020
1ef5dd1
Add additional test case
skmcgrail Aug 26, 2020
a653990
Address feedback
skmcgrail Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
### SDK Enhancements

### SDK Bugs
* `private/protocol`: Limit iso8601 fractional second precision to milliseconds ([#3507](https://github.com/aws/aws-sdk-go/pull/3507))
* Fixes [#3498](https://github.com/aws/aws-sdk-go/issues/3498)
4 changes: 2 additions & 2 deletions private/protocol/timestamp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const (
// RFC3339 a subset of the ISO8601 timestamp format. e.g 2014-04-29T18:30:38Z
ISO8601TimeFormat = "2006-01-02T15:04:05.999999999Z"

// This format is used for output time without seconds precision
// This format is used for output time with fractional second precision up to milliseconds
ISO8601OutputTimeFormat = "2006-01-02T15:04:05.999999999Z"
)

Expand All @@ -48,7 +48,7 @@ func IsKnownTimestampFormat(name string) bool {

// FormatTime returns a string value of the time.
func FormatTime(name string, t time.Time) string {
t = t.UTC()
t = t.UTC().Truncate(time.Millisecond)

switch name {
case RFC822TimeFormatName:
Expand Down
5 changes: 5 additions & 0 deletions private/protocol/timestamp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ func TestFormatTime(t *testing.T) {
expectedOutput: "2000-01-02T20:34:56.123Z",
input: time.Date(2000, time.January, 2, 20, 34, 56, .123e9, time.UTC),
},
"ISO8601Test3": {
formatName: ISO8601TimeFormatName,
expectedOutput: "2000-01-02T20:34:56.123Z",
input: time.Date(2000, time.January, 2, 20, 34, 56, .123456e9, time.UTC),
},
}

for name, c := range cases {
Expand Down