Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit iso8601 fractional second precision to milliseconds #3507

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Aug 26, 2020

Limits the iso8601 time format to milliseconds precision when serializing fractional seconds. This prevents issues seen with services like CloudWatch which don't support nanoseconds granular clock sources.

Fixes #3498

@skmcgrail skmcgrail requested a review from jasdel August 26, 2020 18:58
@skmcgrail skmcgrail merged commit 9ff9264 into aws:master Aug 28, 2020
aws-sdk-go-automation pushed a commit that referenced this pull request Aug 28, 2020
===

### Service Client Updates
* `service/cloudfront`: Updates service API and documentation
  * You can now manage CloudFront's additional, real-time metrics with the CloudFront API.
* `service/cur`: Updates service API and documentation
  * This release add MONTHLY as the new supported TimeUnit for ReportDefinition.
* `service/elasticmapreduce`: Updates service API, documentation, and paginators
  * Amazon EMR adds support for ICMP, port -1, in Block Public Access Exceptions and API access for EMR Notebooks execution. You can now non-interactively execute EMR Notebooks and pass input parameters.
* `service/route53`: Updates service documentation
  * Documentation updates for Route 53

### SDK Bugs
*  `private/protocol`: Limit iso8601 fractional second precision to milliseconds ([#3507](#3507))
  * Fixes [#3498](#3498)
aws-sdk-go-automation added a commit that referenced this pull request Aug 28, 2020
Release v1.34.13 (2020-08-28)
===

### Service Client Updates
* `service/cloudfront`: Updates service API and documentation
  * You can now manage CloudFront's additional, real-time metrics with the CloudFront API.
* `service/cur`: Updates service API and documentation
  * This release add MONTHLY as the new supported TimeUnit for ReportDefinition.
* `service/elasticmapreduce`: Updates service API, documentation, and paginators
  * Amazon EMR adds support for ICMP, port -1, in Block Public Access Exceptions and API access for EMR Notebooks execution. You can now non-interactively execute EMR Notebooks and pass input parameters.
* `service/route53`: Updates service documentation
  * Documentation updates for Route 53

### SDK Bugs
*  `private/protocol`: Limit iso8601 fractional second precision to milliseconds ([#3507](#3507))
  * Fixes [#3498](#3498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Regression with CloudWatch Timestamps in v1.34.9
2 participants