aws: Add config option to unmarshal API response header maps to normalized lower case map keys #3033

skmcgrail · 2019-12-19T19:14:22Z

This adds support for normalizing AWS REST encoded/decoded headers. This resolves an outstanding customer ask #445 which documents the behavior of both Go net/http layer canonicalizing headers that are received in HTTP responses, in addition to the AWS SDK also enforcing that these returned headers be canonicalized as well. Enabling this flag will result in these types of headers being sent as lower-cased to AWS services, and responses targeting the header location will have the headers lower-cased during unmarshaling.

aws/config.go

aws/awsutil/strings.go

aws/awsutil/strings_test.go

private/model/api/load.go

private/protocol/rest/build.go

skotambkar

Looks good, have minor suggestions.

jasdel

I think we should consider if normalized headers should apply to HTTP header marshal, not just unmarshal.

Also CHANGELOG_PENDING would be good for this, calling out fixes to related issues.

private/protocol/rest/build.go

private/protocol/rest/unmarshal.go

… prefix matching

… contain user input when sent or received from a service.

private/protocol/restjson/build_test.go

aws/config.go

jasdel · 2020-01-06T23:45:08Z

Would be good to add CHANGELOG_PENDING.md entry

=== ### Service Client Updates * `service/AWSMigrationHub`: Updates service API, documentation, and paginators * `service/codebuild`: Updates service API and documentation * Add encryption key override to StartBuild API in AWS CodeBuild. * `service/xray`: Updates service documentation * Documentation updates for xray ### SDK Enhancements * `aws`: Add configuration option enable the SDK to unmarshal API response header maps to normalized lower case map keys. ([#3033](#3033)) * Setting `aws.Config.LowerCaseHeaderMaps` to `true` will result in S3's X-Amz-Meta prefixed header to be unmarshaled to lower case Metadata member's map keys. ### SDK Bugs * `aws/ec2metadata` : Reduces request timeout for EC2Metadata client along with maximum number of retries ([#3066](#3066)) * Reduces latency while fetching response from EC2Metadata client running in a container to around 3 seconds * Fixes [#2972](#2972)

Release v1.27.2 (2020-01-07) === ### Service Client Updates * `service/AWSMigrationHub`: Updates service API, documentation, and paginators * `service/codebuild`: Updates service API and documentation * Add encryption key override to StartBuild API in AWS CodeBuild. * `service/xray`: Updates service documentation * Documentation updates for xray ### SDK Enhancements * `aws`: Add configuration option enable the SDK to unmarshal API response header maps to normalized lower case map keys. ([#3033](#3033)) * Setting `aws.Config.LowerCaseHeaderMaps` to `true` will result in S3's X-Amz-Meta prefixed header to be unmarshaled to lower case Metadata member's map keys. ### SDK Bugs * `aws/ec2metadata` : Reduces request timeout for EC2Metadata client along with maximum number of retries ([#3066](#3066)) * Reduces latency while fetching response from EC2Metadata client running in a container to around 3 seconds * Fixes [#2972](#2972)

skmcgrail requested a review from jasdel December 19, 2019 19:14

jasdel suggested changes Dec 20, 2019

View reviewed changes

aws/config.go Outdated Show resolved Hide resolved

aws/awsutil/strings.go Outdated Show resolved Hide resolved