Address Feedback

aws · Jan 6, 2020 · 02a5e66 · 02a5e66
1 parent 5e9c1a2
commit 02a5e66
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/private/protocol/rest/build.go b/private/protocol/rest/build.go
@@ -107,7 +107,7 @@ func buildLocationElements(r *request.Request, v reflect.Value, buildGETQuery bo
 			var err error
 			switch field.Tag.Get("location") {
 			case "headers": // header maps
-				err = buildHeaderMap(&r.HTTPRequest.Header, m, field.Tag, aws.BoolValue(r.Config.LowerCaseHeaderMaps))
+				err = buildHeaderMap(&r.HTTPRequest.Header, m, field.Tag)
 			case "header":
 				err = buildHeader(&r.HTTPRequest.Header, m, name, field.Tag)
 			case "uri":
@@ -173,7 +173,7 @@ func buildHeader(header *http.Header, v reflect.Value, name string, tag reflect.
 	return nil
 }
 
-func buildHeaderMap(header *http.Header, v reflect.Value, tag reflect.StructTag, normalize bool) error {
+func buildHeaderMap(header *http.Header, v reflect.Value, tag reflect.StructTag) error {
 	prefix := tag.Get("locationName")
 	for _, key := range v.MapKeys() {
 		str, err := convertType(v.MapIndex(key), tag)
@@ -186,12 +186,7 @@ func buildHeaderMap(header *http.Header, v reflect.Value, tag reflect.StructTag,
 		keyStr := strings.TrimSpace(key.String())
 		str = strings.TrimSpace(str)
 
-		if normalize {
-			lk := strings.ToLower(prefix + keyStr)
-			(*header)[lk] = append((*header)[lk], str)
-		} else {
-			header.Add(prefix+keyStr, str)
-		}
+		header.Add(prefix+keyStr, str)
 	}
 	return nil
 }

diff --git a/private/protocol/rest/rest_test.go b/private/protocol/rest/rest_test.go
@@ -97,8 +97,8 @@ func TestNormalizedHeaders(t *testing.T) {
 				"BAR": aws.String("barValue"),
 			},
 			expectedInputHeaders: http.Header{
-				"x-amz-meta-baz": []string{"bazValue"},
-				"x-amz-meta-bar": []string{"barValue"},
+				"X-Amz-Meta-Baz": []string{"bazValue"},
+				"X-Amz-Meta-Bar": []string{"barValue"},
 			},
 			outputValues: http.Header{
 				"X-Amz-Meta-Baz": []string{"bazValue"},