Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Smithy to 1.52.1 #2881

Merged
merged 9 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .DS_Store
Binary file not shown.
12 changes: 12 additions & 0 deletions .changelog/f2df419d89d44856b08d3e5afb013b83.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"id": "f2df419d-89d4-4856-b08d-3e5afb013b83",
"type": "dependency",
"description": "Update Smithy to 1.52.1 and update tests",
"modules": [
"internal/protocoltest/awsrestjson",
"internal/protocoltest/jsonrpc",
"internal/protocoltest/jsonrpc10",
"internal/protocoltest/restxml",
"internal/protocoltest/smithyrpcv2cbor"
]
}
2 changes: 1 addition & 1 deletion SMITHY_GO_CODEGEN_VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e6338ca9b5ee30c6317ea908173a369a9d3eb236
48250f49d98ad6bed6c302a8af97f62cc7f3bd83
2 changes: 1 addition & 1 deletion codegen/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
smithyVersion=1.50.0
smithyVersion=1.52.1
smithyGradleVersion=0.7.0
Original file line number Diff line number Diff line change
Expand Up @@ -150,18 +150,6 @@ public static void generateHttpProtocolTests(GenerationContext context) {
.service(ShapeId.from("aws.protocoltests.json10#JsonRpc10"))
.operation(ShapeId.from("aws.protocoltests.json10#OperationWithNestedStructure"))
.addTestName("AwsJson10ClientPopulatesNestedDefaultValuesWhenMissing")
.build(),

// TODO these tests are currently failing due to tests not being updated, see #2825
HttpProtocolUnitTestGenerator.SkipTest.builder()
.service(ShapeId.from("aws.protocoltests.restjson#RestJson"))
.operation(ShapeId.from("aws.protocoltests.restjson#NullAndEmptyHeadersClient"))
.addTestName("RestJsonNullAndEmptyHeaders")
.build(),
HttpProtocolUnitTestGenerator.SkipTest.builder()
.service(ShapeId.from("aws.protocoltests.restxml#RestXml"))
.operation(ShapeId.from("aws.protocoltests.restxml#NullAndEmptyHeadersClient"))
.addTestName("NullAndEmptyHeaders")
.build()
));

Expand Down Expand Up @@ -227,6 +215,7 @@ public static void generateHttpProtocolTests(GenerationContext context) {
.addTestName("AwsJson10ClientPopulatesDefaultsValuesWhenMissingInResponse")
.addTestName("AwsJson10ClientIgnoresDefaultValuesIfMemberValuesArePresentInResponse")
.build(),
// We don't populate default values if none are sent by the server
HttpProtocolUnitTestGenerator.SkipTest.builder()
.service(ShapeId.from("aws.protocoltests.json10#JsonRpc10"))
.operation(ShapeId.from("aws.protocoltests.json10#OperationWithNestedStructure"))
Expand All @@ -236,6 +225,11 @@ public static void generateHttpProtocolTests(GenerationContext context) {
.service(ShapeId.from("aws.protocoltests.json10#JsonRpc10"))
.operation(ShapeId.from("aws.protocoltests.json10#OperationWithRequiredMembers"))
.addTestName("AwsJson10ClientErrorCorrectsWhenServerFailsToSerializeRequiredValues")
.build(),
HttpProtocolUnitTestGenerator.SkipTest.builder()
.service(ShapeId.from("aws.protocoltests.json10#JsonRpc10"))
.operation(ShapeId.from("aws.protocoltests.json10#OperationWithRequiredMembersWithDefaults"))
.addTestName("AwsJson10ClientErrorCorrectsWithDefaultValuesWhenServerFailsToSerializeRequiredValues")
.build()
));

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading