Update Smithy to 1.52.1 #2881
Merged
Update Smithy to 1.52.1 #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Oct 31, 2024
wty-Bryant
approved these changes
Oct 31, 2024
lucix-aws
reviewed
Oct 31, 2024
SMITHY_GO_CODEGEN_VERSION
Outdated
| @@ -1 +1 @@ | |||
| e6338ca9b5ee30c6317ea908173a369a9d3eb236 | |||
| 48250f49d98ad6bed6c302a8af97f62cc7f3bd83 | |||
There was a problem hiding this comment.
Hold on, is this right?
this seems to be the latest (w/ smithy upgrade)
There was a problem hiding this comment.
Great catch, will update it
|
Discussed with Smithy, this is related to smithy-lang/smithy#2432 From Swift who also faced this issue
|
|
@Madrigal could you please add |
|
@erka will send another PR to add other common stuff to |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes
I wasn't expecting these many protocol tests to be updated by bringing in the latest version. Did a quick check of one that we brought in with this release (this one) and it seems to have been introduced in 1.41, so unsure why it wasn't being generated.
Relies on aws/smithy-go#550