-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat java21 runtime #6261
Merged
Merged
Feat java21 runtime #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add java21 runtime * Add test_data for java21 and update gh action to use java21 * Update tests/integration/testdata/buildcmd/Java/gradlew/21/gradle/wrapper/gradle-wrapper.properties Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> --------- Co-authored-by: Wing Fung Lau <[email protected]>
* Add java21 runtime * Add test_data for java21 and update gh action to use java21 * Update tests/integration/testdata/buildcmd/Java/gradlew/21/gradle/wrapper/gradle-wrapper.properties Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * attempt to fix gradle build test failure * attempt to fix gradle build test failure * upgrade gradle wrapper * upgrading gradle wrapper --------- Co-authored-by: Haresh Nasit <[email protected]> Co-authored-by: Haresh Nasit <[email protected]>
github-actions
bot
added
area/local/start-api
sam local start-api command
area/build
sam build command
area/local/invoke
sam local invoke command
area/local/start-invoke
pr/internal
labels
Nov 14, 2023
hnnasit
approved these changes
Nov 15, 2023
mndeveci
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to change gradlew file for java11?
mndeveci
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
sam build command
area/local/invoke
sam local invoke command
area/local/start-api
sam local start-api command
area/local/start-invoke
pr/internal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.