Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat java21 runtime #6261

Merged
merged 17 commits into from
Nov 16, 2023
Merged

Feat java21 runtime #6261

merged 17 commits into from
Nov 16, 2023

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Nov 14, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hnnasit and others added 6 commits October 17, 2023 10:56
* Add java21 runtime

* Add test_data for java21 and update gh action to use java21

* Update tests/integration/testdata/buildcmd/Java/gradlew/21/gradle/wrapper/gradle-wrapper.properties

Co-authored-by: Wing Fung Lau <[email protected]>

* Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml

Co-authored-by: Wing Fung Lau <[email protected]>

* Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml

Co-authored-by: Wing Fung Lau <[email protected]>

---------

Co-authored-by: Wing Fung Lau <[email protected]>
* Add java21 runtime

* Add test_data for java21 and update gh action to use java21

* Update tests/integration/testdata/buildcmd/Java/gradlew/21/gradle/wrapper/gradle-wrapper.properties

Co-authored-by: Wing Fung Lau <[email protected]>

* Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml

Co-authored-by: Wing Fung Lau <[email protected]>

* Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml

Co-authored-by: Wing Fung Lau <[email protected]>

* attempt to fix gradle build test failure

* attempt to fix gradle build test failure

* upgrade gradle wrapper

* upgrading gradle wrapper

---------

Co-authored-by: Haresh Nasit <[email protected]>
Co-authored-by: Haresh Nasit <[email protected]>
@hawflau hawflau requested a review from a team as a code owner November 14, 2023 05:02
@hawflau hawflau requested review from mndeveci and lucashuy November 14, 2023 05:02
@github-actions github-actions bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke pr/internal labels Nov 14, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to change gradlew file for java11?

@mndeveci mndeveci enabled auto-merge November 16, 2023 06:40
@mndeveci mndeveci added this pull request to the merge queue Nov 16, 2023
Merged via the queue into aws:develop with commit b939df3 Nov 16, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants