-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed spacing typo #559
Merged
Merged
Fixed spacing typo #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running 'sam local start-lambda' it logged "templatethrough" rather than "template through"
jfuss
approved these changes
Jul 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces are hard :)
Thanks for the fix!
Congrats on the first PR :)
heitorlessa
added a commit
to heitorlessa/aws-sam-cli
that referenced
this pull request
Jul 21, 2018
* develop: docs: Fix @mhart link in README (aws#562) docs: Change jest to mocha in Nodejs init README (aws#564) docs: Fix syntax highlighting in README.md (aws#561) fix: spacing typo in Log statement in start-lambda (aws#559) fix: Functional tests must run on localhost to work in Windows (aws#552) docs: Adding readme for "sam logs" and "sam local start-lambda" command (aws#557) docs: Accessibility and help text changes (aws#554) chore: Preparing for release - v0.5.0 (aws#553) feat(LocalLambdaService): Integ test for start-lambda command (aws#550)
jfuss
added a commit
that referenced
this pull request
Aug 28, 2018
* fix: Functional tests must run on localhost to work in Windows (#552) * fix: spacing typo in Log statement in start-lambda (#559) * docs: Fix syntax highlighting in README.md (#561) * docs: Change jest to mocha in Nodejs init README (#564) * docs: Fix @mhart link in README (#562) * docs(README): removed cloudtrail, added SNS to generate-event (#569) * docs: Update repo name references (#577) * feat(debugging): Fixing issues around debugging Golang functions. (#565) * fix(init): Improve current init samples around docs and fixes (#558) * docs(README): Update launch config to SAM CLI from SAM Local (#587) * docs(README): Update sample code for calling Local Lambda Invoke (#584) * refactor(init): renamed handler for camel case, moved callback call up (#586) * chore: aws-lambda-java-core 1.1.0 -> 1.2.0 for java sam init (#578) * feat(validate): Add profile and region options (#582) Currently, `sam validate` requires AWS Creds (due to the SAM Translator). This commits adds the ability to pass in the credientials through a profile that is configured through `aws configure`. * docs(README): Update README prerequisites to include awscli (#596) * fix(start-lambda): Remove Content-Type Header check (#594) * docs: Disambiguation "Amazon Kinesis" (#599) * docs: Adding instructions for how to add pyenv to your PATH for Windows (#600) * docs: Update README with small grammar fix (#601) * fix: Update link in NodeJS package.json (#603) * docs: Creating instructions for Windows users to install sam (#605) * docs: Adding a note directing Windows users to use pipenv (#606) * fix: Fix stringifying λ environment variables when using Python2 (#579) * feat(generate-event): Added support for 50+ events (#612) * feat(invoke): Add region parameter to all invoke related commands (#608) * docs: Breaking up README into separate files to make it easier to read (#607) * chore: Update JVM size params to match docker-lambda (#615) * feat(invoke): Invoke Function Without Parameters through --no-event (#604) * docs: Update advanced_usage.rst with clarification on --env-vars usage (#610) * docs: Remove an extra word in the sam packaging command (#618) * UX: Improves event names to reflect Lambda Event Sources (#619) * docs: Fix git clone typo in installation docs (#630) * docs(README): Callout go1.x runtime support (#631) * docs(installation): Update sam --version command (#634) * chore(0.6.0): SAM CLI Version bump (#635)
hawflau
added a commit
to hawflau/aws-sam-cli
that referenced
this pull request
Nov 14, 2023
* Add java21 runtime * Add test_data for java21 and update gh action to use java21 * Update tests/integration/testdata/buildcmd/Java/gradlew/21/gradle/wrapper/gradle-wrapper.properties Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * attempt to fix gradle build test failure * attempt to fix gradle build test failure * upgrade gradle wrapper * upgrading gradle wrapper --------- Co-authored-by: Haresh Nasit <[email protected]> Co-authored-by: Haresh Nasit <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
* feat: Add java21 runtime support (#553) * Add java21 runtime * Add test_data for java21 and update gh action to use java21 * Update tests/integration/testdata/buildcmd/Java/gradlew/21/gradle/wrapper/gradle-wrapper.properties Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> --------- Co-authored-by: Wing Fung Lau <[email protected]> * Revert "feat: Add java21 runtime support (#553)" (#558) This reverts commit 10f670e. * Sam cli java21 runtime (#559) * Add java21 runtime * Add test_data for java21 and update gh action to use java21 * Update tests/integration/testdata/buildcmd/Java/gradlew/21/gradle/wrapper/gradle-wrapper.properties Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * Update tests/integration/testdata/buildcmd/Java/maven/21/pom.xml Co-authored-by: Wing Fung Lau <[email protected]> * attempt to fix gradle build test failure * attempt to fix gradle build test failure * upgrade gradle wrapper * upgrading gradle wrapper --------- Co-authored-by: Haresh Nasit <[email protected]> Co-authored-by: Haresh Nasit <[email protected]> * fix: fix the runtime to schema code binding mapping (#566) * update build.yml to setup multiple java versions * Update build.yml * revert java8 gradlew testdata * revert java8 gradlew testdata * Revert "revert java8 gradlew testdata" This reverts commit a9337db. * Revert "revert java8 gradlew testdata" This reverts commit def09bd. * setup multiple versions of jdk --------- Co-authored-by: Haresh Nasit <[email protected]> Co-authored-by: Haresh Nasit <[email protected]> Co-authored-by: Mohamed ElAsmar <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When running 'sam local start-lambda' it logged "templatethrough" rather than "template through"
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.