add TypeScript hello world template w/ Lambda Powertools integration #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bpauwels
commented
Feb 23, 2022
bpauwels
commented
- feat: add TypeScript hello world template w/ Lambda Powertools for TypeScript integration
- Update manifest to include new workflow
|
as discussed with romboiko@; |
mndeveci
requested changes
May 12, 2022
There was a problem hiding this comment.
Thanks for your contribution, can you move changes from manifest.json file into manifest-v2.json and some testing? Example testing for existing nodejs14 can be found here: https://github.com/aws/aws-sam-cli-app-templates/blob/master/tests/integration/unit_test/test_unit_test_nodejs14_x.py
Rest looks good to me.
manifest.json
Outdated
| @@ -323,6 +323,14 @@ | |||
| "packageType": "Zip", | |||
| "useCaseName": "Hello World Example" | |||
| }, | |||
| { | |||
| "directory": "nodejs14.x/cookiecutter-aws-sam-hello-powertools-typescript-nodejs", | |||
There was a problem hiding this comment.
Can you move this information into manifest-v2.json file?
There was a problem hiding this comment.
Hi, I've just done so! I see you have updates to node16.x - should I change this in my structure or is it done when merging?
…hub.com/bpauwels/aws-sam-cli-app-templates into node-ts-hello-world-powertools-template
mndeveci
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.