Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set client ID in samples #541

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Set client ID in samples #541

merged 3 commits into from
Dec 30, 2024

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Dec 27, 2024

Issue #, if available:

Some samples miss client ID, so an IoT broker sets it to some random value.
Discovered in this PR: #539

Description of changes:

Add default client ID value set to test-<RANDOM VALUE>. And where possible, add an option for client ID.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sfod sfod marked this pull request as ready for review December 30, 2024 18:08
@sfod sfod changed the title Add client ID to samples Set client ID to samples Dec 30, 2024
@sfod sfod changed the title Set client ID to samples Set client ID in samples Dec 30, 2024
@sfod sfod merged commit 71ebf28 into main Dec 30, 2024
11 of 12 checks passed
@sfod sfod deleted the add-client-id-to-samples branch December 30, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants