Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add clientId so that it can connect using auto created policy,… #539

Closed
wants to merge 1 commit into from

Conversation

wopperer
Copy link

… typo fix

Because auto-assigned clientId is not included in the policy

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… typo fix

Because auto-assigned clientId is not included in the policy
@sfod
Copy link
Contributor

sfod commented Dec 27, 2024

Thanks for the contribution, the samples should definitely allow setting client IDs.
But I'm afraid this PR will break our CI - multiple CI jobs will start connecting with the same client ID disconnecting each other.
Instead, we need add two things:

We'll implement this logic in this and maybe other similar samples.
Thanks again for highlighting this issue.

@wopperer
Copy link
Author

@sfod yes I also thought about adding the options but then I was not sure, if there was maybe a reason for not having them. Thanks for taking care of it!

@sfod sfod closed this Dec 27, 2024
@sfod sfod mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants