Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by clang static analysis #895

Merged
merged 1 commit into from
Apr 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions samples/linux/jobs_sample/jobs_sample.c
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,10 @@ int main(int argc, char **argv) {
paramsQOS0.payloadLen = strlen(cPayload);

rc = aws_iot_jobs_send_query(&client, QOS0, AWS_IOT_MY_THING_NAME, NULL, NULL, topicToPublishGetPending, sizeof(topicToPublishGetPending), NULL, 0, JOB_GET_PENDING_TOPIC);
if(SUCCESS != rc) {
IOT_ERROR("Error calling aws_iot_jobs_send_query: %d ", rc);
return rc;
}

AwsIotDescribeJobExecutionRequest describeRequest;
describeRequest.executionNumber = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/aws_iot_mqtt_client_common_internal.c
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ IoT_Error_t aws_iot_mqtt_internal_init_header(MQTTHeader *pHeader, MessageTypes
IoT_Error_t aws_iot_mqtt_internal_send_packet(AWS_IoT_Client *pClient, size_t length, Timer *pTimer) {

size_t sentLen, sent;
IoT_Error_t rc;
IoT_Error_t rc = FAILURE;

FUNC_ENTRY;

Expand Down
1 change: 0 additions & 1 deletion src/aws_iot_mqtt_client_connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,6 @@ IoT_Error_t aws_iot_mqtt_disconnect(AWS_IoT_Client *pClient) {

IoT_Error_t aws_iot_mqtt_attempt_reconnect(AWS_IoT_Client *pClient) {
IoT_Error_t rc;
ClientState currentState = aws_iot_mqtt_get_client_state(pClient);

FUNC_ENTRY;

Expand Down