Fix issues reported by clang static analysis #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following issues were reported: 1. Uninitialized variable in aws_iot_mqtt_internal_send_packet function resulted in garbage return value. 2. currentState variable in aws_iot_mqtt_attempt_reconnect was not used. 3. Return value from aws_iot_jobs_send_query function was not checked in the jobs sample. This commit addresses the above issues. These were reported here: #882 Signed-off-by: Gaurav Aggarwal <[email protected]>
gordonwang0
approved these changes
Apr 27, 2020
leegeth
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues were reported:
aws_iot_mqtt_internal_send_packetfunction resulted in garbage return value.currentStatevariable inaws_iot_mqtt_attempt_reconnectwas not used.aws_iot_jobs_send_queryfunction was not checked in the jobs sample.This commit addresses the above issues.
These were reported here: #882
Signed-off-by: Gaurav Aggarwal [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.