feat: Allow users to override the default deploy tool workspace directory #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
requested changes
Jun 16, 2022
src/AWS.Deploy.Orchestration/Utilities/EnvironmentVariableManager.cs
Outdated
Show resolved
Hide resolved
96malhar
force-pushed
the
kmalhar/handle-spaces-in-profile
branch
from
3515765 to
95a54a3
Compare
96malhar
force-pushed
the
kmalhar/handle-spaces-in-profile
branch
3 times, most recently
from
d2df8e9 to
bb0af2f
Compare
Reworked the PR to use dependency injection and added an integ test. |
96malhar
force-pushed
the
kmalhar/handle-spaces-in-profile
branch
2 times, most recently
from
4f197d2 to
cb0d0a4
Compare
normj
approved these changes
Jun 18, 2022
96malhar
force-pushed
the
kmalhar/handle-spaces-in-profile
branch
from
cb0d0a4 to
a5bff28
Compare
philasmar
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
DOTNET-6010
Description of changes:
The PR gives users the ability to set their custom deploy tool workspace directory. They can do so by setting a user scoped or machine scoped environment variable called
AWS_DOTNET_DEPLOYTOOL_WORKSPACE. This variable must point to a directory that exists on the disk and does not contain any whitespace characters.This PR also solves the issue of failed deployments when the user profile path contains a whitespace character - #579
The underlying issue is with CDK and not with our deployment tool - aws/aws-cdk#2532 and aws/jsii#1296
Without the setting the
AWS_DOTNET_DEPLOYTOOL_WORKSPACEenvironment variableThe same deployment is successful after the
AWS_DOTNET_DEPLOYTOOL_WORKSPACEenvironment variableBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.