JSII crashes if a " " is present in the JsiiRuntimePath path

[gregswdl]

🐛 Bug Report

Affected Languages

• TypeScript or Javascript
• Python
• Java
• .NET (C#, F#, ...)

General Information

• JSII Version: 0.22.0
• Platform: Windows 10 Pro

What is the problem?

This issue was discovered trying to use the CDK, however I believe it is ultimately in JSII. As stated above, I'm running the .NET Core 3 version on Windows 10. My Windows login is my full name, Greg Smith. The issue is that my temp dir path is C:\Users\Greg Smith\AppData\Local\Temp and when the node process is run with the JSII package, node will crash with

Unhandled exception. Amazon.JSII.Runtime.JsiiException: Child process exited unexpectedly: internal/modules/cjs/loader.js:638

I was able to trace the issue down to the ProcessStartInfo object. The arguments simply attach the JsiiRuntimePth from the provider and spaces are interpreted as a new argument by node, equivelant to the following:

C:\Users\Greg Smith>node --max-old-space-size=4096 C:\Users\Greg Smith\AppData\Local\Temp\zmqnhp2i.n2w\jsii-runtime.js
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'C:\Users\Greg'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)

However, wrapping with quotes yeilds:

C:\Users\Greg Smith>node --max-old-space-size=4096 "C:\Users\Greg Smith\AppData\Local\Temp\zmqnhp2i.n2w\jsii-runtime.js"
{"hello":"@jsii/[email protected]"}

Verbose Log

gist of log

[gregswdl]

Note, as a temporary workaround you can set your TMP path to something without spaces, eg

PS C:\> $env:TMP = "C:\tmp"

[github-actions]

This issue has not received any attention in 2 years. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[ashovlin]

Could we reopen this if it hasn't been resolved?

I work on https://github.com/aws/aws-dotnet-deploy, which generates CDK projects based on user's .NET applications. My hunch is we have a higher likelihood of users on Windows than the other language bindings.

We provide an environment variable to let users override the path where our tool is generating the CDK projects, but it's still a sharp edge. Here's an example from last week.