feat(eks): managed nodegroup support #6759

pahud · 2020-03-17T03:56:25Z

Description

implement the Nodegroup resource from AWS::EKS::Nodegroup
support cluster.addNodegroup(id, {...}) which creates a default nodegroup for the cluster
integ test
unit tests
100% test coverage
update README

Commit Message

feat(aws-eks): managed nodegroup support (#6759 )

BREAKING CHANGE: Cluster now creates a default managed nodegroup as its default capacity. Set the new cluster property defaultCapacityType to DefaultCapacityType.EC2 to preserve EC2 as its default capacity.

Closes #5086

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation · 2020-03-17T04:17:35Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 1686081
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

- minor fix

pahud · 2020-03-17T05:14:50Z

copy @eladb

aws-cdk-automation · 2020-03-17T05:17:56Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: d28b856
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T06:27:03Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 0fd3398
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-eks/lib/cluster.ts

packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

Co-Authored-By: Elad Ben-Israel <[email protected]>

aws-cdk-automation · 2020-03-17T23:44:13Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 17a34ac
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:45:12Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 7662429
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:45:39Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 3075be0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:46:21Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 7662429
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:46:54Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 055a918
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:47:06Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 055a918
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:48:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 29d5907
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:48:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: c5e77b6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:48:24Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: f060878
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-17T23:51:19Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: f52094d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-18T01:47:00Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 433ce36
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-03-23T06:34:05Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: a3ba7ca
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb

I believe we should add a BREAKING CHANGE notice in the commit message.

pahud · 2020-03-25T00:51:31Z

I believe we should add a BREAKING CHANGE notice in the commit message.

OK. In the commit message now.

aws-cdk-automation · 2020-03-25T01:37:49Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: c267cb1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-eks/README.md

eladb · 2020-03-25T07:27:01Z

packages/@aws-cdk/aws-eks/lib/cluster.ts

@@ -312,7 +320,7 @@ export class Cluster extends Resource implements ICluster {
   * The auto scaling group that hosts the default capacity for this cluster.
   * This will be `undefined` if the default capacity is set to 0.
   */
-  public readonly defaultCapacity?: autoscaling.AutoScalingGroup;
+  public readonly defaultCapacity?: Nodegroup | autoscaling.AutoScalingGroup;


Sadly this won’t work with jsii languages like Java so we don’t use unions.

Let’s just use defaultNodegroup for the nodegroup version.

Sure! Let me fix it.

aws-cdk-automation · 2020-03-25T08:05:37Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 5c6a74b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

pahud · 2020-03-25T10:42:15Z

@eladb

Now we have both defaultCapacity and defaultNodegroup. Please review again.

aws-cdk-automation · 2020-03-25T11:20:43Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: e13286d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb

😍

mergify · 2020-03-25T11:28:49Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

pahud · 2020-03-25T11:30:27Z

😍

I am crying ! Have learned a lot from it. Thanks!!

aws-cdk-automation · 2020-03-25T12:27:41Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 9f7df9a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-03-25T12:28:03Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

pahud · 2020-04-03T14:17:40Z

Hi @eladb

I just noticed this blog post from EKS team:

Upcoming Changes to IP Assignment for EKS Managed Node Groups
https://aws.amazon.com/tw/blogs/containers/upcoming-changes-to-ip-assignment-for-eks-managed-node-groups/

Today, an EKS managed node group automatically assigns public IP addresses to all nodes that it launches. When a public IP address is assigned using the AssociatePublicIpAddress flag on an EC2 instance or launch template, it overrides the settings in the subnet. This means that if your VPC is configured with the public + private subnet or private only subnet architectures, public IPs are still assigned to the nodes that are instantiated in the private subnets.

I am afraid users would be confused as we deploy the Nodegroup by default in the private subnets while they still see public IP addresses being assigned.

aws-cdk/packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

Line 240 in 5d1253d

subnets: this.cluster.vpc.selectSubnets(props.subnets).subnetIds,

However, this behavior, according to the blog post, will be changed starting April 20, 2020. And CDK doesn't have to do anything for it. By that time, all clusters created by CDK will by default have a managed nodegroup in private subnet and no public IP addresses will be automatically assigned.

Do we need to note this somewhere?

farshadniayeshpour · 2020-04-03T18:10:39Z

Hi @eladb I am trying to add a managed nodegroup to my cluster but I cannot find the eks.NodeGroup anywhere on the API documentation. Can you help me with how to create a managed node group with CDK in Python?

https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/aws-eks

farshadniayeshpour · 2020-04-03T18:13:02Z

Also, do I need to create an AutoScalingGroup to make sure I have a manged node group?

farshadniayeshpour · 2020-04-03T19:17:55Z

@pahud can you help me figure out how to enable managed node groups in eks?

pahud · 2020-04-04T00:06:38Z

@FarshadNiayesh

I think we can't use it in Python until CDK 1.32.0 released(should be in the next few days). According to the document, we will have a new addNodeGroup() method to create managed nodegroups with cluster. I believe in python we can do something like this

# create a cluster with default managed nodegroup
cluster = aws_eks.Cluster()
# add an extra manaded nodegroup
cluster.add_nodegroup()

farshadniayeshpour · 2020-04-04T12:15:58Z

Thank you for your answer. @pahud I had another question. When I try to install helm charts in specific namespaces, I always get an error from the Cloudformation console when the stack is in "Create in progress" mode. Seems like the helm chart cannot create the specified namespace.

Do you know how I can pre-create namespaces with eks.cluster() and then pass them to the eks.chart()?

pahud · 2020-04-05T01:54:35Z

Thank you for your answer. @pahud I had another question. When I try to install helm charts in specific namespaces, I always get an error from the Cloudformation console when the stack is in "Create in progress" mode. Seems like the helm chart cannot create the specified namespace.

Do you know how I can pre-create namespaces with eks.cluster() and then pass them to the eks.chart()?

If you create Helm Charts with addChart() method, you may specify namespace.

see the python reference here
https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_eks/Cluster.html#aws_cdk.aws_eks.Cluster.add_chart

Given this thread is for managed nodegroup, let's discuss Helm Chart on gitter(awslabs/aws-cdk) or create another issue if necessary.

initial nodegroup support

1686081

- update README

d28b856

- minor fix

update integ test

0fd3398

eladb reviewed Mar 17, 2020

View reviewed changes

pahud and others added 8 commits March 18, 2020 07:24

Update packages/@aws-cdk/aws-eks/lib/cluster.ts

17a34ac

Co-Authored-By: Elad Ben-Israel <[email protected]>

Update packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

7662429

Co-Authored-By: Elad Ben-Israel <[email protected]>

Update packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

3075be0

Co-Authored-By: Elad Ben-Israel <[email protected]>

Update packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

055a918

Co-Authored-By: Elad Ben-Israel <[email protected]>

Update packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

29d5907

Co-Authored-By: Elad Ben-Israel <[email protected]>

Update packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

f060878

Co-Authored-By: Elad Ben-Israel <[email protected]>

Update packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts

c5e77b6

Co-Authored-By: Elad Ben-Israel <[email protected]>

Merge branch 'master' into managed-ng

f52094d

pahud added 2 commits March 18, 2020 09:00

minor fix

433ce36

remove duplicate

df44c52

add unit tests

a098055

pahud requested a review from eladb March 23, 2020 05:49

eladb suggested changes Mar 24, 2020

View reviewed changes

Merge branch 'master' into managed-ng

c267cb1

pahud requested a review from eladb March 25, 2020 00:52

eladb suggested changes Mar 25, 2020

View reviewed changes

packages/@aws-cdk/aws-eks/README.md Show resolved Hide resolved

pahud added 2 commits March 25, 2020 15:04

Add defaultCapacityType swith

70471fd

merge branch 'managed-ng' of github.com:pahud/aws-cdk into managed-ng

5c6a74b

eladb reviewed Mar 25, 2020

View reviewed changes

add defaultNodegroup support and update the test and README

e13286d

pahud requested a review from eladb March 25, 2020 10:42

eladb approved these changes Mar 25, 2020

View reviewed changes

Merge branch 'master' into managed-ng

9f7df9a

mergify bot merged commit 74169bf into aws:master Mar 25, 2020

feat(eks): managed nodegroup support #6759

feat(eks): managed nodegroup support #6759

Conversation

pahud commented Mar 17, 2020 • edited Loading

Description

Commit Message

End Commit Message

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

pahud commented Mar 17, 2020

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 18, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Mar 23, 2020

AWS CodeBuild CI Report

eladb left a comment

Choose a reason for hiding this comment

pahud commented Mar 25, 2020

aws-cdk-automation commented Mar 25, 2020

AWS CodeBuild CI Report

eladb Mar 25, 2020

Choose a reason for hiding this comment

pahud Mar 25, 2020

Choose a reason for hiding this comment

aws-cdk-automation commented Mar 25, 2020

AWS CodeBuild CI Report

pahud commented Mar 25, 2020

aws-cdk-automation commented Mar 25, 2020

AWS CodeBuild CI Report

eladb left a comment

Choose a reason for hiding this comment

mergify bot commented Mar 25, 2020

pahud commented Mar 25, 2020

aws-cdk-automation commented Mar 25, 2020

AWS CodeBuild CI Report

mergify bot commented Mar 25, 2020

pahud commented Apr 3, 2020

farshadniayeshpour commented Apr 3, 2020 • edited Loading

farshadniayeshpour commented Apr 3, 2020

farshadniayeshpour commented Apr 3, 2020

pahud commented Apr 4, 2020

farshadniayeshpour commented Apr 4, 2020

pahud commented Apr 5, 2020

pahud commented Mar 17, 2020 •

edited

Loading

farshadniayeshpour commented Apr 3, 2020 •

edited

Loading