Skip to content

Commit

Permalink
chore: lock in TypeScript dependency for monocdk (#7159)
Browse files Browse the repository at this point in the history
Without the TypeScript `devDependency` directly recorded on
`monocdk-experiment`, `yarn build+test` doesn't work.

Why?

* `yarn build+test` runs `npm run build && npm test`.
* `npm run build` builds a tool $PATH that ONLY includes
  the dependencies of the `monocdk-experiment` package itself
  (not the `$ROOT/node_modules/.bin` directory of the monorepo).
* Since `tsc` is not in the `npm run` path, the system `tsc` will
  be used.
* If the system `tsc` is older than `3.8`, the compilation step
  will fail.
  • Loading branch information
rix0rrr authored Apr 3, 2020
1 parent 95ab44b commit 5d1253d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/monocdk-experiment/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"typescript": "~3.8.3",
"constructs": "2.0.0",
"@aws-cdk/alexa-ask": "0.0.0",
"@aws-cdk/app-delivery": "0.0.0",
Expand Down

0 comments on commit 5d1253d

Please sign in to comment.