Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elbv2): access logging for NLB #6197

Merged
merged 3 commits into from
Feb 11, 2020
Merged

fix(elbv2): access logging for NLB #6197

merged 3 commits into from
Feb 11, 2020

Conversation

rzamana
Copy link
Contributor

@rzamana rzamana commented Feb 10, 2020

Moving the method logAccessLogs to the Base Load Balancer, so both types
of Load Balancer (Network and Application) can use the method.

closes #3794
Fix partially #4319


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Moving the method logAccessLogs to the Base Load Balancer, so both types
of Load Balancer (Network and Application) can use the method.

closes #3794
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title fix(elasticloadbalancingv2): logAccessLogs in Base Load Balancer fix(elbv2): access logging for NLB Feb 11, 2020
@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit adbc3b9 into aws:master Feb 11, 2020
mergify bot pushed a commit that referenced this pull request Jan 16, 2023
…k/lambda-layer-awscli (#23700)

Bumps [awscli](https://github.com/aws/aws-cli) from 1.27.45 to 1.27.50.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p>
<blockquote>
<h1>1.27.50</h1>
<ul>
<li>api-change:<code>connect</code>: This release updates the responses of UpdateContactFlowContent, UpdateContactFlowMetadata, UpdateContactFlowName and DeleteContactFlow API with empty responses.</li>
<li>api-change:<code>ec2</code>: Documentation updates for EC2.</li>
<li>api-change:<code>outposts</code>: This release adds POWER_30_KVA as an option for PowerDrawKva. PowerDrawKva is part of the RackPhysicalProperties structure in the CreateSite request.</li>
<li>api-change:<code>resource-groups</code>: AWS Resource Groups customers can now turn on Group Lifecycle Events in their AWS account. When you turn this on, Resource Groups monitors your groups for changes to group state or membership. Those changes are sent to Amazon EventBridge as events that you can respond to using rules you create.</li>
</ul>
<h1>1.27.49</h1>
<ul>
<li>api-change:<code>cleanrooms</code>: Initial release of AWS Clean Rooms</li>
<li>api-change:<code>lambda</code>: Add support for MaximumConcurrency parameter for SQS event source. Customers can now limit the maximum concurrent invocations for their SQS Event Source Mapping.</li>
<li>api-change:<code>logs</code>: Bug fix: logGroupName is now not a required field in GetLogEvents, FilterLogEvents, GetLogGroupFields, and DescribeLogStreams APIs as logGroupIdentifier can be provided instead</li>
<li>api-change:<code>mediaconvert</code>: The AWS Elemental MediaConvert SDK has added support for compact DASH manifest generation, audio normalization using TruePeak measurements, and the ability to clip the sample range in the color corrector.</li>
<li>api-change:<code>secretsmanager</code>: Update documentation for new ListSecrets and DescribeSecret parameters</li>
</ul>
<h1>1.27.48</h1>
<ul>
<li>api-change:<code>kendra</code>: This release adds support to new document types - RTF, XML, XSLT, MS_EXCEL, CSV, JSON, MD</li>
</ul>
<h1>1.27.47</h1>
<ul>
<li>api-change:<code>location</code>: This release adds support for two new route travel models, Bicycle and Motorcycle which can be used with Grab data source.</li>
<li>api-change:<code>rds</code>: This release adds support for configuring allocated storage on the CreateDBInstanceReadReplica, RestoreDBInstanceFromDBSnapshot, and RestoreDBInstanceToPointInTime APIs.</li>
</ul>
<h1>1.27.46</h1>
<ul>
<li>bugfix:<code>codeartifact login</code>: Fix parsing of dotnet output for aws codeartifact login command; fixes <code>[#6197](aws/aws-cli#6197) &lt;https://github.com/aws/aws-cli/issues/6197&gt;</code>__</li>
<li>api-change:<code>ecr-public</code>: This release for Amazon ECR Public makes several change to bring the SDK into sync with the API.</li>
<li>api-change:<code>kendra-ranking</code>: Introducing Amazon Kendra Intelligent Ranking, a new set of Kendra APIs that leverages Kendra semantic ranking capabilities to improve the quality of search results from other search services (i.e. OpenSearch, ElasticSearch, Solr).</li>
<li>api-change:<code>network-firewall</code>: Network Firewall now supports the Suricata rule action reject, in addition to the actions pass, drop, and alert.</li>
<li>api-change:<code>ram</code>: Enabled FIPS aws-us-gov endpoints in SDK.</li>
<li>api-change:<code>workspaces-web</code>: This release adds support for a new portal authentication type: AWS IAM Identity Center (successor to AWS Single Sign-On).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/aws-cli/commit/8f288486271a6c312a8cb9e6c68551ddc400a1b6"><code>8f28848</code></a> Merge branch 'release-1.27.50'</li>
<li><a href="https://github.com/aws/aws-cli/commit/31258e8caf29ca7f1c1b3a86ef1457dfc58ee4cb"><code>31258e8</code></a> Bumping version to 1.27.50</li>
<li><a href="https://github.com/aws/aws-cli/commit/04240aafd0419c600a921c2196f36923871bc37c"><code>04240aa</code></a> Update changelog based on model updates</li>
<li><a href="https://github.com/aws/aws-cli/commit/f4f065c93b834684ceb3bccef646a51ea7c128cf"><code>f4f065c</code></a> Merge branch 'release-1.27.49'</li>
<li><a href="https://github.com/aws/aws-cli/commit/16f4c995189f4ff38133b098daded5a5cd827fa9"><code>16f4c99</code></a> Merge branch 'release-1.27.49' into develop</li>
<li><a href="https://github.com/aws/aws-cli/commit/d7afe3baf68b2019dab83bce3b2613dd750f8e67"><code>d7afe3b</code></a> Bumping version to 1.27.49</li>
<li><a href="https://github.com/aws/aws-cli/commit/fc389d4ec77b26d67e83d9d0bcc3ac7246a4bab9"><code>fc389d4</code></a> Update changelog based on model updates</li>
<li><a href="https://github.com/aws/aws-cli/commit/bf5c31b4c46ce2e656f16775c4f53507293ee6d2"><code>bf5c31b</code></a> Merge branch 'release-1.27.48'</li>
<li><a href="https://github.com/aws/aws-cli/commit/8474cafd9358e44ea29699e57ce2a4299a4a1348"><code>8474caf</code></a> Merge branch 'release-1.27.48' into develop</li>
<li><a href="https://github.com/aws/aws-cli/commit/44b32370f6aae87fa5acefedc2359f64b2cef4a0"><code>44b3237</code></a> Bumping version to 1.27.48</li>
<li>Additional commits viewable in <a href="https://github.com/aws/aws-cli/compare/1.27.45...1.27.50">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=awscli&package-manager=pip&previous-version=1.27.45&new-version=1.27.50)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants