Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticloadbalancingv2.NetworkLoadBalancer should have a log_access_logs method such as ApplicationLoadBalancer has #3794

Closed
2 tasks
imajinos opened this issue Aug 26, 2019 · 2 comments · Fixed by #6197
Closed
2 tasks

elasticloadbalancingv2.NetworkLoadBalancer should have a log_access_logs method such as ApplicationLoadBalancer has #3794

imajinos opened this issue Aug 26, 2019 · 2 comments · Fixed by #6197
Assignees
@rix0rrr
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.

Comments

@imajinos
Copy link

🚀 Feature Request

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

The NetworkLoadBalancer construct appears to be missing a log_access_logs (err., logAccessLogs in ts-speak) method for enabling and configuring access logs to s3. ApplicationLoadBalancer has this method which is why I see this as 'missing'

Proposed Solution

Environment

  • CDK CLI Version: 1.5.0
  • Module Version: 1.5.0
  • OS: all
  • Language: all

Other information
@imajinos imajinos added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 26, 2019
@imajinos
Copy link
Author

work-around / implementation (sorry, this is python style):

netlb.set_attribute('access_logs.s3.bucket', self.lblogs.bucket_name)
netlb.set_attribute('access_logs.s3.prefix', self.lbNetPrefix)
netlb.set_attribute('access_logs.s3.enabled', 'true')

@NGL321 NGL321 added gap @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing @aws-cdk/aws-s3 Related to Amazon S3 and removed needs-triage This issue or PR still needs to be triaged. @aws-cdk/aws-s3 Related to Amazon S3 labels Aug 27, 2019
@NGL321
Copy link
Contributor

NGL321 commented Aug 27, 2019

@imajinos Thank you for bringing this up! It looks like you are correct, and this is missing.

Thank you for posting a workaround for the interim until someone on the team is able to address it!

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jan 23, 2020
@rzamana rzamana mentioned this issue Feb 10, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Feb 10, 2020
@mergify mergify bot closed this as completed in #6197 Feb 11, 2020
mergify bot added a commit that referenced this issue Feb 11, 2020
@rzamana @mergify
fix(elasticloadbalancingv2): logAccessLogs in Base Load Balancer (#6197)
adbc3b9 
Moving the method logAccessLogs to the Base Load Balancer, so both types
of Load Balancer (Network and Application) can use the method.

closes #3794

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this issue Feb 11, 2020
@rzamana @mergify
fix(elbv2): validate rule priority is a positive number (#6222)
1fbaafe 
* fix(elasticloadbalancingv2): logAccessLogs in Base Load Balancer

Moving the method logAccessLogs to the Base Load Balancer, so both types
of Load Balancer (Network and Application) can use the method.

closes #3794

* fix(elbv2): Validating if priority is greater than ZERO

The Application Load Balancer does not accepts priority equal or less
than ZERO. Throws an error if passes ZERO or less.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(elbv2): access logging for NLB
4 participants
@rix0rrr @NGL321 @imajinos @SomayaB