feat(eks): default capacity #3633
Merged
+502
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2019 10:36
When defining an EKS cluster, the `vpc` property is now optional. If not specified, a VPC will be defined with the default configuration for this environment. It can then be accessed through `cluster.vpc`. Fixes #3541
By default, allocate 2x m5.large instances when defining an EKS cluster. This can be configured through `defaultCapacity` and `defaultCapacityInstance` or by setting `defaultCapacity` to `0` and invoking `cluster.addCapacity`. BREAKING CHANGE: clusters will be created with a default capacity of x2 m5.large instances. You can specify `defaultCapacity: 0` if you wish to disable.
|
2xm5.large is the default capacity of eksctl. I agree we align with eksctl. |
SanderKnape
reviewed
Aug 13, 2019
skinny85
previously approved these changes
Aug 13, 2019
RomainMuller
previously approved these changes
Aug 13, 2019
RomainMuller
approved these changes
Aug 13, 2019
skinny85
approved these changes
Aug 13, 2019
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, allocate 2x m5.large instances when defining an EKS cluster. This can be configured
through
defaultCapacityanddefaultCapacityInstanceor by settingdefaultCapacityto0and invoking
cluster.addCapacity.Fixes #3631
BREAKING CHANGE: clusters will be created with a default capacity of x2 m5.large instances. You can specify
defaultCapacity: 0if you wish to disable.Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license