Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-eks] Default vpc #3541

Closed
1 task done
eladb opened this issue Aug 5, 2019 · 0 comments · Fixed by #3632
Closed
1 task done

[aws-eks] Default vpc #3541

eladb opened this issue Aug 5, 2019 · 0 comments · Fixed by #3632
Assignees
@eladb @iliapolo
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service

Comments

@eladb
Copy link
Contributor

eladb commented Aug 5, 2019

  • I'm submitting a ...

    • 🚀 feature request

  • What is the current behavior?

When an EKS cluster is defined, users need to explicitly specify the VPC and explicitly add capacity to the cluster.

Originally posted by @arun-gupta in #3510

  • What is the expected behavior (or behavior of feature suggested)?

  • Make ClusterProps.vpc optional (and define a default vpc)

  • Automatically define initial capacity unless this feature is disabled (we need to think of the right API).

  • What is the motivation / use case for changing the behavior or adding this feature?

We want to make it easier for users to get started with sensible defaults, similar to how eksctl works.

  • Please tell us about your environment:

    • CDK CLI Version: 1.3.0
    • Module Version: 1.3.0
    • OS: all
    • Language: all
@eladb eladb mentioned this issue Aug 5, 2019
Merged
@eladb eladb added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Aug 12, 2019
@eladb eladb self-assigned this Aug 12, 2019
@eladb eladb changed the title eks: default vpc and capacity eks: default vpc Aug 13, 2019
eladb pushed a commit that referenced this issue Aug 13, 2019
feat(eks): default vpc
36ff71c 
When defining an EKS cluster, the `vpc` property is now
optional. If not specified, a VPC will be defined with
the default configuration for this environment.

It can then be accessed through `cluster.vpc`.

Fixes #3541
@eladb eladb mentioned this issue Aug 13, 2019
Merged
@mergify mergify bot closed this as completed in #3632 Aug 13, 2019
mergify bot pushed a commit that referenced this issue Aug 13, 2019
@mergify
feat(eks): default vpc (#3632)
3a96c27 
When defining an EKS cluster, the `vpc` property is now
optional. If not specified, a VPC will be defined with
the default configuration for this environment.

It can then be accessed through `cluster.vpc`.

Fixes #3541
mergify bot pushed a commit that referenced this issue Aug 13, 2019
@mergify
feat(eks): default capacity (#3633)
91af473 
* feat(eks): default vpc

When defining an EKS cluster, the `vpc` property is now
optional. If not specified, a VPC will be defined with
the default configuration for this environment.

It can then be accessed through `cluster.vpc`.

Fixes #3541

* feat(eks): default capacity

By default, allocate 2x m5.large instances when defining an EKS cluster. This can be configured
through `defaultCapacity` and `defaultCapacityInstance` or by setting `defaultCapacity` to `0`
and invoking `cluster.addCapacity`.

BREAKING CHANGE: clusters will be created with a default capacity of x2 m5.large instances. You can specify `defaultCapacity: 0` if you wish to disable.

* Fix typo

* fix a few merge errors
@iliapolo iliapolo changed the title eks: default vpc [aws-eks] Default vpc Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

@iliapolo iliapolo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eks): default vpc aws/aws-cdk
2 participants
@eladb @iliapolo