Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update check-build-prerequisites.sh to include .NET 9 #32298

Closed

Conversation

ashishdhingra
Copy link
Contributor

Issue # (if applicable)

Closes #32282.

Reason for this change

Add support for .NET 9 if it is the only SDK installed on user's machine.

Description of changes

Updates check-build-prerequisites.sh to include .NET 9.

Description of how you validated changes

Ran expression locally echo $app_v | grep -c -E "[6789]\.[0-9]+\.[0-9]+.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 labels Nov 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 26, 2024 22:19
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 26, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ashishdhingra ashishdhingra changed the title chore: Update check-build-prerequisites.sh to include .NET 9 chore: update check-build-prerequisites.sh to include .NET 9 Nov 26, 2024
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (7cc5f30) to head (c22f921).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32298   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         105      105           
  Lines        7168     7168           
  Branches     1314     1314           
=======================================
  Hits         5553     5553           
  Misses       1433     1433           
  Partials      182      182           
Flag Coverage Δ
suite.unit 77.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.46% <ø> (ø)

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 26, 2024 22:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c22f921
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 26, 2024
@gracelu0
Copy link
Contributor

Thanks @ashishdhingra , there was a duplicate PR opened earlier: #32158 which I just approved so I will close this one.

@gracelu0 gracelu0 closed this Nov 30, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(repo tooling): cannot install with dotnet 9
3 participants