Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(repo tooling): cannot install with dotnet 9 #32282

Closed
1 task
kirkwaiblinger opened this issue Nov 26, 2024 · 4 comments · Fixed by #32158
Closed
1 task

(repo tooling): cannot install with dotnet 9 #32282

kirkwaiblinger opened this issue Nov 26, 2024 · 4 comments · Fixed by #32158
Assignees
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI

Comments

@kirkwaiblinger
Copy link

Describe the bug

when running yarn build as a new contributor, and installing dotnet in order to address the build requirements check, I get

Checking dotnet version... Found dotnet version 9.0.100 [/usr/local/share/dotnet/sdk]. Install dotnet >= 6.0.100

9.9.100 is plainly >= 6.0.100, so I propose the erorr message be updated to match the actual requirements in order to make setup accessible for new contributors.

Related: #17605

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

No error, or error message like

Checking dotnet version... Found dotnet version 9.0.100 [/usr/local/share/dotnet/sdk]. Install dotnet >= 6.0.100 and < 9

Current Behavior

Checking dotnet version... Found dotnet version 9.0.100 [/usr/local/share/dotnet/sdk]. Install dotnet >= 6.0.100

Reproduction Steps

yarn build on a machine with dotnet == 9.0.100

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

n/a. This is on main, commit 0153da4

Framework Version

No response

Node.js Version

v22.11.0

OS

macos

Language

TypeScript

Language Version

n/a

Other information

It would also be helpful if the error message when dotnet is missing gave mentioned referring to the CONTRIBUTING.md for .NET SDK installation instructions. I searched for dotnet in CONTRIBUTING.md and found nothing.

@kirkwaiblinger kirkwaiblinger added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 26, 2024
@kirkwaiblinger
Copy link
Author

Oh, it would also be helpful if the gitpod instructions were mentioned before the Quick Start instructions. That's a great feature for contributors, but I didn't know it to use it because I was trying to follow the directions in order 🤦‍♂️

@ashishdhingra ashishdhingra self-assigned this Nov 26, 2024
@ashishdhingra ashishdhingra added p2 needs-reproduction This issue needs reproduction. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
@ashishdhingra
Copy link
Contributor

Reproducible (also when executing scripts/check-build-prerequisites.sh)

Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if docker is installed... Ok
Checking if Docker is running... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Found dotnet version 9.0.100 [/local/home/ashdhin/.dotnet/sdk]. Install dotnet >= 6.0.100
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Need to modify RegEx at

if [ $(echo $app_v | grep -c -E "[678]\.[0-9]+\.[0-9]+") -eq 1 ]
.

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed needs-reproduction This issue needs reproduction. labels Nov 26, 2024
@mergify mergify bot closed this as completed in #32158 Nov 30, 2024
@mergify mergify bot closed this as completed in 6931632 Nov 30, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
2 participants