Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(build.sh): dotnet 6.x.x not supported by check-build-prerequisites.sh #17605

Closed
markussiebert opened this issue Nov 19, 2021 · 1 comment · Fixed by #17606
Closed

(build.sh): dotnet 6.x.x not supported by check-build-prerequisites.sh #17605

markussiebert opened this issue Nov 19, 2021 · 1 comment · Fixed by #17606
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI

Comments

@markussiebert
Copy link
Contributor

markussiebert commented Nov 19, 2021 •
edited
Loading

What is the problem?

Trying to build cdk on an apple m1 mac, where .net 6 is the only native supported version

Reproduction Steps

run build.sh with dotnet 6 installed (https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-6.0.100-macos-arm64-installer)

What did you expect to happen?

build.sh should run fine

What actually happened?

I got an error message

Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Found dotnet version 6.0.100 [/usr/local/share/dotnet/sdk]. Install dotnet >= 3.1.0

CDK CLI Version

none

Framework Version

1.132

Node.js Version

14.17.0

OS

macOS

Language

Typescript

Language Version

No response

Other information

No response
@markussiebert markussiebert added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2021
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 19, 2021
@markussiebert markussiebert mentioned this issue Nov 19, 2021
Merged
@NGL321 NGL321 added the p1 label Nov 22, 2021
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed p1 needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2021
@rix0rrr rix0rrr removed their assignment Nov 22, 2021
@mergify mergify bot closed this as completed in #17606 Nov 22, 2021
mergify bot pushed a commit that referenced this issue Nov 22, 2021
@markussiebert
chore: dotnet 6 support for building cdk (#17606)
2b34abb 
fixes: #17605 
```bash
Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Ok
Checking if python3 is installed... Ok
Checking python3 version... Ok
```

and everything seems to build fine

Think fixes to test files are unnecessary, and don't know what to document for this...

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@markussiebert @TikiTDO
chore: dotnet 6 support for building cdk (aws#17606)
b37cfa1 
fixes: aws#17605 
```bash
Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Ok
Checking if python3 is installed... Ok
Checking python3 version... Ok
```

and everything seems to build fine

Think fixes to test files are unnecessary, and don't know what to document for this...

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kirkwaiblinger kirkwaiblinger mentioned this issue Nov 26, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: dotnet 6 support for building cdk
3 participants
@rix0rrr @NGL321 @markussiebert