Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make @aws-cdk/yargs-gen a devDependency #32096

Merged
merged 3 commits into from
Nov 12, 2024
Merged

chore: make @aws-cdk/yargs-gen a devDependency #32096

merged 3 commits into from
Nov 12, 2024

Commits on Nov 12, 2024

  1. chore: make @aws-cdk/yargs-gen a devDependency 

    `yargs-gen` used to be a runtime dependency. The only reason seemed to
be that there was a factory class for `DynamicResult` types in
`yargs-gen`, called `DynamicValue`.

In this PR, move the factory to the only location where it is used
in the CLI itself, and turn the `import` of `yargs-gen` into an
`import type`, which does not imply any runtime dependency.
    @rix0rrr
    rix0rrr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3478c7e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into huijbers/yargsgen-devdep

    @rix0rrr
    rix0rrr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    879995f View commit details
    Browse the repository at this point in the history

  3. Remove dependency

    @rix0rrr
    rix0rrr committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b0af12b View commit details
    Browse the repository at this point in the history