chore: make @aws-cdk/yargs-gen a devDependency
#32096
Conversation
`yargs-gen` used to be a runtime dependency. The only reason seemed to be that there was a factory class for `DynamicResult` types in `yargs-gen`, called `DynamicValue`. In this PR, move the factory to the only location where it is used in the CLI itself, and turn the `import` of `yargs-gen` into an `import type`, which does not imply any runtime dependency.
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32096 +/- ##
==========================================
+ Coverage 77.28% 77.30% +0.02%
==========================================
Files 114 114
Lines 7628 7628
Branches 1360 1360
==========================================
+ Hits 5895 5897 +2
+ Misses 1551 1549 -2
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rix0rrr
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-cli-test-run
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
yargs-genused to be a runtime dependency. The only reason seemed to be that there was a factory class forDynamicResulttypes inyargs-gen, calledDynamicValue.In this PR, move the factory to the only location where it is used in the CLI itself, and turn the
importofyargs-geninto animport type, which does not imply any runtime dependency.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license