-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): default BastionHostLinux to use Amazon Linux 2023 (under feature flag) #31996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
7a433bf
to
cdd23d6
Compare
@@ -18,9 +18,6 @@ | |||
"VPCPublicSubnet1SubnetB4246D30": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the old integration tests, since AL2023 is the new default with the feature flag on. I added an integration test disabling the flag, which can be removed when v3 is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Merge conflicts resolved. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31996 +/- ##
=======================================
Coverage 78.50% 78.50%
=======================================
Files 106 106
Lines 7201 7201
Branches 1321 1321
=======================================
Hits 5653 5653
Misses 1361 1361
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this high quality work!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue #29493
Closes #29493
Reason for this change
Right now, if a
machineImage
property isn't passed toBastionHostLinux
, it defaults to an Amazon Linux 2 image. Since Amazon Linux 2 is hitting end-of-life in June 2025, it'd be better to default to Amazon Linux 2023.Since changing this default would be a breaking change, I placed it behind a feature flag,
@aws-cdk/aws-ec2:bastionHostUseAmazonLinux2023ByDefault
.Description of changes
@aws-cdk/aws-ec2:bastionHostUseAmazonLinux2023ByDefault
machineImage
is not provided, we use the latest Amazon Linux 2023 image, instead of Amazon Linux 2.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license