community review workflow stuck with Action Required state

[tmokmss]

Describe the bug

Hi, apparently the community review workflow is not working now. It seems an approval from a maintainer is required to run the PR linter workflow. PR: #31212

These runs are left pending since yesterday: #1, #2

Can someone from the core team approve the workflow execution? Also, do we need the approval for each PR?

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

PR linter workflow runs and if there is an approval review, a tag (pr/needs-maintainer-review) is added. As described here.

Current Behavior

PR linter workflow stuck with pending approval.

Reproduction Steps

leave a community review to a PR.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.163.1

Framework Version

No response

Node.js Version

20

OS

macos

Language

TypeScript

Language Version

No response

Other information

No response

[khushail]

Hi @tmokmss ,thanks for reporting this.

Can someone from the core team approve the workflow execution? Also, do we need the approval for each PR?

AFAIK, approval for each PR is not needed.

Reaching out to core team, requesting their inputs and action.

[khushail]

@tmokmss , got to know from the team that they are aware of this issue and already working towards its resolution.

I would be moving this issue to team's project board for visibility and further action.

Appreciate you having patience here !

[kaizencc]

Thanks for bringing this up @tmokmss. I don't think our existing github action triggers will work with our new settings anymore. The best I can think of is creating a new github action that runs hourly over all open PRs and either runs the linter or just the community review workflow. It won't be as nice as a trigger on reviews, but it will be better than what we have now :/

I'll try to get this up and running this week.

[kaizencc]

Hi @tmokmss, the underlying setting was changed back to what it used to be -- require approval for first time contributors. I'm keeping this ticket open until we can confirm that the community review workflow works again. I would really appreciate it if you can let me know if one of your reviews works without manual intervention!

[tmokmss]

Hi @kaizencc sorry for the delayed response. I approved another PR #31996 but am afraid it is not working as expected. It is not getting a new label although the OP is not a first time contributor.

edit) apparently it is now working!

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.