Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): Role.addManagedPolicy() does not work for imported roles IRole #8307 #31212

Merged
merged 11 commits into from
Dec 6, 2024
Merged

fix(iam): Role.addManagedPolicy() does not work for imported roles IRole #8307 #31212

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4efe2f3
fix(iam): does not work for imported roles #8307
stm29 Aug 24, 2024
dbe344b
If Role is imported, we should allow Edit the Role anymore, as this w…
stm29 Aug 25, 2024
699479d
Merge branch 'main' into issue_8307
stm29 Oct 20, 2024
f07668a
Fixed Comments
stm29 Oct 20, 2024
a832873
Fixed Integration tests
stm29 Oct 20, 2024
38f93e3
Fixed comments and altered aws-s3-notifications
stm29 Oct 21, 2024
21fdf4a
Added only One Common warning
stm29 Oct 22, 2024
5c116fd
Fixing Unit Tests
stm29 Oct 22, 2024
7513f82
Merge branch 'main' into issue_8307
paulhcsun Nov 27, 2024
f5066af
Rerverting to main - notifications-resource-handler.ts
stm29 Nov 27, 2024
36deb38
Merge branch 'main' into issue_8307
GavinZZ Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .../test/aws-iam/test/integ.imported-role.js.snapshot/ImportedRoleTestAssertions.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

192 changes: 189 additions & 3 deletions ...est/aws-iam/test/integ.imported-role.js.snapshot/ImportedRoleTestAssertions.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"PolicyNames.2",
"PolicyNames.3"
],
"salt": "1697413484207"
"salt": "1729447009370"
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
Expand Down Expand Up @@ -73,6 +73,15 @@
"Resource": [
"*"
]
},
{
"Action": [
"iam:ListAttachedRolePolicies"
],
"Effect": "Allow",
"Resource": [
"*"
]
}
]
}
Expand All @@ -83,12 +92,20 @@
"SingletonFunction1488541a7b23466481b69b4408076b81HandlerCD40AE9F": {
"Type": "AWS::Lambda::Function",
"Properties": {
"Runtime": "nodejs18.x",
"Runtime": {
"Fn::FindInMap": [
"LatestNodeRuntimeMap",
{
"Ref": "AWS::Region"
},
"value"
]
},
"Code": {
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "c91921c142e824b74d06797a2be74eab5d0dd0453e753549f5182ac7a02f556b.zip"
"S3Key": "e77649078c9dea5bbb707b7fe68014cfa5d919a38d31b467f6a205b51ea63a83.zip"
},
"Timeout": 120,
"Handler": "index.handler",
Expand All @@ -99,6 +116,43 @@
]
}
}
},
"AwsApiCallIAMlistAttachedRolePolicies7b6e565f3b40bc5c7faa65c17a68f5be": {
"Type": "Custom::DeployAssert@SdkCallIAMlistAttachedRolePolicies",
"Properties": {
"ServiceToken": {
"Fn::GetAtt": [
"SingletonFunction1488541a7b23466481b69b4408076b81HandlerCD40AE9F",
"Arn"
]
},
"service": "IAM",
"api": "listAttachedRolePolicies",
"expected": "{\"$StringLike\":\"^MyCustomManagedPolicy[0-9]$\"}",
"actualPath": "AttachedPolicies.1.PolicyName",
"parameters": {
"RoleName": {
"Fn::Join": [
"",
[
"\"",
{
"Fn::ImportValue": "integ-iam-imported-role-3:ExportsOutputRefroleToBeImportedCAC1213CDE38D2C6"
},
"\""
]
]
}
},
"flattenResponse": "true",
"outputPaths": [
"AttachedPolicies.0.PolicyName",
"AttachedPolicies.1.PolicyName"
],
"salt": "1729447009371"
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
}
},
"Outputs": {
Expand All @@ -109,6 +163,138 @@
"assertion"
]
}
},
"AssertionResultsAwsApiCallIAMlistAttachedRolePolicies7b6e565f3b40bc5c7faa65c17a68f5be": {
"Value": {
"Fn::GetAtt": [
"AwsApiCallIAMlistAttachedRolePolicies7b6e565f3b40bc5c7faa65c17a68f5be",
"assertion"
]
}
}
},
"Mappings": {
"LatestNodeRuntimeMap": {
"af-south-1": {
"value": "nodejs20.x"
},
"ap-east-1": {
"value": "nodejs20.x"
},
"ap-northeast-1": {
"value": "nodejs20.x"
},
"ap-northeast-2": {
"value": "nodejs20.x"
},
"ap-northeast-3": {
"value": "nodejs20.x"
},
"ap-south-1": {
"value": "nodejs20.x"
},
"ap-south-2": {
"value": "nodejs20.x"
},
"ap-southeast-1": {
"value": "nodejs20.x"
},
"ap-southeast-2": {
"value": "nodejs20.x"
},
"ap-southeast-3": {
"value": "nodejs20.x"
},
"ap-southeast-4": {
"value": "nodejs20.x"
},
"ap-southeast-5": {
"value": "nodejs20.x"
},
"ap-southeast-7": {
"value": "nodejs20.x"
},
"ca-central-1": {
"value": "nodejs20.x"
},
"ca-west-1": {
"value": "nodejs20.x"
},
"cn-north-1": {
"value": "nodejs18.x"
},
"cn-northwest-1": {
"value": "nodejs18.x"
},
"eu-central-1": {
"value": "nodejs20.x"
},
"eu-central-2": {
"value": "nodejs20.x"
},
"eu-isoe-west-1": {
"value": "nodejs18.x"
},
"eu-north-1": {
"value": "nodejs20.x"
},
"eu-south-1": {
"value": "nodejs20.x"
},
"eu-south-2": {
"value": "nodejs20.x"
},
"eu-west-1": {
"value": "nodejs20.x"
},
"eu-west-2": {
"value": "nodejs20.x"
},
"eu-west-3": {
"value": "nodejs20.x"
},
"il-central-1": {
"value": "nodejs20.x"
},
"me-central-1": {
"value": "nodejs20.x"
},
"me-south-1": {
"value": "nodejs20.x"
},
"mx-central-1": {
"value": "nodejs20.x"
},
"sa-east-1": {
"value": "nodejs20.x"
},
"us-east-1": {
"value": "nodejs20.x"
},
"us-east-2": {
"value": "nodejs20.x"
},
"us-gov-east-1": {
"value": "nodejs18.x"
},
"us-gov-west-1": {
"value": "nodejs18.x"
},
"us-iso-east-1": {
"value": "nodejs18.x"
},
"us-iso-west-1": {
"value": "nodejs18.x"
},
"us-isob-east-1": {
"value": "nodejs18.x"
},
"us-west-1": {
"value": "nodejs20.x"
},
"us-west-2": {
"value": "nodejs20.x"
}
}
},
"Parameters": {
Expand Down
Loading