Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): Role.addManagedPolicy() does not work for imported roles IRole #8307 #31212

Merged
merged 11 commits into from
Dec 6, 2024

Merge branch 'main' into issue_8307

36deb38
Select commit
Loading
Failed to load commit list.
Merged

fix(iam): Role.addManagedPolicy() does not work for imported roles IRole #8307 #31212

Merge branch 'main' into issue_8307
36deb38
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Dec 6, 2024 in 4s

8 potential rules

⚠️ The pull request has been merged by @GavinZZ

Rule: automatic merge (queue)

  • -closed
  • -closed [📌 queue requirement]
  • -merged
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • -label~=(blocked|do-not-merge|no-squash|two-approvers)
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
      • any of: [🛡 GitHub branch protection]
        • check-success = validate-pr
        • check-neutral = validate-pr
        • check-skipped = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch
        • check-neutral = codecov/patch
        • check-skipped = codecov/patch
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch/packages/aws-cdk
        • check-neutral = codecov/patch/packages/aws-cdk
        • check-skipped = codecov/patch/packages/aws-cdk
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project
        • check-neutral = codecov/project
        • check-skipped = codecov/project
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project/packages/aws-cdk
        • check-neutral = codecov/project/packages/aws-cdk
        • check-skipped = codecov/project/packages/aws-cdk

Rule: automatic merge (comment)

  • -closed
  • -merged
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash|two-approvers)
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge (2+ approvers) (queue)

  • #approved-reviews-by>=2
  • -closed
  • -closed [📌 queue requirement]
  • -merged
  • label~=two-approvers
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • -label~=(blocked|do-not-merge|no-squash)
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
      • any of: [🛡 GitHub branch protection]
        • check-success = validate-pr
        • check-neutral = validate-pr
        • check-skipped = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch
        • check-neutral = codecov/patch
        • check-skipped = codecov/patch
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch/packages/aws-cdk
        • check-neutral = codecov/patch/packages/aws-cdk
        • check-skipped = codecov/patch/packages/aws-cdk
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project
        • check-neutral = codecov/project
        • check-skipped = codecov/project
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project/packages/aws-cdk
        • check-neutral = codecov/project/packages/aws-cdk
        • check-skipped = codecov/project/packages/aws-cdk

Rule: automatic merge (2+ approvers) (comment)

  • #approved-reviews-by>=2
  • -closed
  • -merged
  • label~=two-approvers
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash)
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge (no-squash) (queue)

  • -closed
  • -closed [📌 queue requirement]
  • -merged
  • label~=no-squash
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • -label~=(blocked|do-not-merge)
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-merge]
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
      • any of: [🛡 GitHub branch protection]
        • check-success = validate-pr
        • check-neutral = validate-pr
        • check-skipped = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch
        • check-neutral = codecov/patch
        • check-skipped = codecov/patch
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch/packages/aws-cdk
        • check-neutral = codecov/patch/packages/aws-cdk
        • check-skipped = codecov/patch/packages/aws-cdk
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project
        • check-neutral = codecov/project
        • check-skipped = codecov/project
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project/packages/aws-cdk
        • check-neutral = codecov/project/packages/aws-cdk
        • check-skipped = codecov/project/packages/aws-cdk

Rule: automatic merge (no-squash) (comment)

  • -closed
  • -merged
  • label~=no-squash
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge)
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1

Rule: remove stale reviews (dismiss_reviews)

  • -closed
  • -merged
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base=main
  • changes-requested-reviews-by!=aws-cdk-automation
  • label!=contribution/core

Rule: if fails conventional commits (comment)

  • -closed
  • -merged
  • status-failure=Semantic Pull Request
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]

💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!


3 not applicable rules

Rule: label core (label)

  • author~=^(rix0rrr|iliapolo|otaviomacedo|kaizencc|comcalvi|TheRealAmazonKendra|mrgrain|pahud|ashishdhingra|kellertk|HBobertz|sumupitchayan|colifran|moelasmar|paulhcsun|GavinZZ|aaythapa|xazhao|gracelu0|jfuss|shikha372|kirtishrinkhala|godwingrs22|bergjaak|samson-keung|IanKonlog|Leo10Gama|scorbiere|michelle-wangg|jiayiwang7|1kaileychen|saiyush|5d)$
  • -label~="contribution/core"

Rule: automatic merge of Dependabot PRs (queue)

  • -closed
  • -closed [📌 queue requirement]
  • -merged
  • author~=dependabot
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • -label~=(blocked|do-not-merge)
  • -title~=(WIP|wip)
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
      • any of: [🛡 GitHub branch protection]
        • check-success = validate-pr
        • check-neutral = validate-pr
        • check-skipped = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch
        • check-neutral = codecov/patch
        • check-skipped = codecov/patch
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/patch/packages/aws-cdk
        • check-neutral = codecov/patch/packages/aws-cdk
        • check-skipped = codecov/patch/packages/aws-cdk
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project
        • check-neutral = codecov/project
        • check-skipped = codecov/project
      • any of: [🛡 GitHub branch protection]
        • check-success = codecov/project/packages/aws-cdk
        • check-neutral = codecov/project/packages/aws-cdk
        • check-skipped = codecov/project/packages/aws-cdk

Rule: automatic merge of Dependabot PRs (comment)

  • -closed
  • -merged
  • author~=dependabot
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • -label~=(blocked|do-not-merge)
  • -title~=(WIP|wip)
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com