Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): node20 runtime #27897

Merged
merged 2 commits into from
Nov 13, 2023
Merged

feat(lambda): node20 runtime #27897

merged 2 commits into from
Nov 13, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Nov 8, 2023

Preparing for node20 launch


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 8, 2023 16:51
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 8, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Nov 8, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 8, 2023 17:42

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f2e15d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc kaizencc marked this pull request as ready for review November 13, 2023 16:50
Copy link
Contributor

mergify bot commented Nov 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2e3cdd9 into main Nov 13, 2023
14 checks passed
@mergify mergify bot deleted the conroy/node20 branch November 13, 2023 16:51
kaizencc added a commit that referenced this pull request Nov 13, 2023
Preparing for node20 launch

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
Preparing for node20 launch

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Nov 13, 2023
/**
* The NodeJS 20.x runtime (nodejs20.x)
*/
public static readonly NODEJS_20_X = new Runtime('nodejs20.x', RuntimeFamily.NODEJS, { supportsInlineCode: true });
Copy link
Contributor

@unstubbable unstubbable Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an oversight or intentional that NODEJS_LATEST has not been updated as part of this PR?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted, guess it will be changed at a later point.
According to the PR description this is just for "Preparing for node20 launch".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants