Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(csharp): update nodejs version to 20.x #1039

Merged
merged 9 commits into from
May 30, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented May 24, 2024

Similar to #1010
Part of: #961


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@trivikr trivikr force-pushed the csharp-nodejs-version branch from 075871a to 92e85a7 Compare May 24, 2024 04:23
@trivikr
Copy link
Contributor Author

trivikr commented May 29, 2024

I'm not sure why the 'Runtime' does not contain a definition for 'NODEJS_20_X' error is thrown.

The Node.js 20.x runtime was added in v2.109.0 in aws/aws-cdk#27897
And this PR updates the aws-cdk version to v2.133.0 in csharp/package.json

@kaiz-io
Copy link
Contributor

kaiz-io commented May 30, 2024

@trivikr It is your csproj file that controls the lib that your dotnet uses to compile. I removed your change to the csharp/package.json That file control the cdk cli version which I always want to be up to date.

@kaiz-io kaiz-io merged commit 6980ab8 into aws-samples:main May 30, 2024
7 checks passed
@trivikr trivikr deleted the csharp-nodejs-version branch May 30, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants