chore(elasticsearch): remove elasticsearch legacy reference #23943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elastic has followed up with a request that we remove "legacy Elasticsearch" references from our docs for legal reasons. They supplied these two links to remove the string from: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticsearch-readme.html https://docs.aws.amazon.com/cdk/api/v1/docs/aws-elasticsearch-readme.html This PR is for v1 (the second link). Does updating v1 automatically update v2? Closes https://t.corp.amazon.com/V825034754.
github-actions
bot
added
the
beginning-contributor
mrgrain
changed the title
@chatnish FYI in these cases we usually make the PR for v2 (which this one is) and after it's merged we use some automation to backport the change to v1. I will take care of that. |
mrgrain
approved these changes
Feb 1, 2023
|
@Mergifyio backport v1-main |
✅ Backports have been created
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
Elastic has followed up with a request that we remove "legacy Elasticsearch" references from our docs for legal reasons. They supplied these two links to remove the string from: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticsearch-readme.html and https://docs.aws.amazon.com/cdk/api/v1/docs/aws-elasticsearch-readme.html Internal reference: V825034754. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 0a4ad38)
mergify bot
added a commit
that referenced
this pull request
Feb 1, 2023
…23943) (#23949) This is an automatic backport of pull request #23943 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
This was referenced Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elastic has followed up with a request that we remove "legacy Elasticsearch" references from our docs for legal reasons.
They supplied these two links to remove the string from: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticsearch-readme.html and https://docs.aws.amazon.com/cdk/api/v1/docs/aws-elasticsearch-readme.html
Internal reference: V825034754.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license