Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove elasticsearch legacy reference #23942

Closed
wants to merge 1 commit into from

Conversation

chatnish
Copy link
Contributor

@chatnish chatnish commented Feb 1, 2023

Elastic has followed up with a request that we remove "legacy Elasticsearch" references from our docs for legal reasons.

They supplied these two links to remove the string from: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticsearch-readme.html https://docs.aws.amazon.com/cdk/api/v1/docs/aws-elasticsearch-readme.html

This PR is for v1 (the second link). Does updating v1 automatically update v2?

Closes https://t.corp.amazon.com/V825034754.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Elastic has followed up with a request that we remove "legacy Elasticsearch" references from our docs for legal reasons.

They supplied these two links to remove the string from:
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticsearch-readme.html
https://docs.aws.amazon.com/cdk/api/v1/docs/aws-elasticsearch-readme.html

This PR is for v1 (the second link). Does updating v1 automatically update v2?

Closes https://t.corp.amazon.com/V825034754.
@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team February 1, 2023 01:27
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Feb 1, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

@chatnish chatnish closed this Feb 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2023

⚠️ The sha of the head commit of this PR conflicts with #23943. Mergify cannot evaluate rules on this PR. ⚠️

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e0ce66d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants