Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version in lambda layer and fix tests impacted by update #21994

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

TheRealAmazonKendra
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra commented Sep 11, 2022

The EKS and StepFunctions Tasks tests were failing as a result of this upgrade due to the change in the template url
for awscdkawseksKubectlProviderNestedStackawscdkawseksKubectlProviderNestedStackResourceA7AEBA6B
The object key for this asset was changed.

Each of the failing tests have also been updated to use the new integ test construct.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 11, 2022

@github-actions github-actions bot added the p2 label Sep 11, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2022 01:40
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 11, 2022
@Naumel
Copy link
Contributor

Naumel commented Sep 12, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2022

update

✅ Branch has been successfully updated

@Naumel
Copy link
Contributor

Naumel commented Sep 12, 2022

[info] Build output:

@aws-cdk/aws-stepfunctions-tasks: Tests:    3 failed, 36 total
@aws-cdk/aws-stepfunctions-tasks: Error: Some tests failed!

dependabot bot and others added 3 commits September 12, 2022 07:38
Bumps [awscli](https://github.com/aws/aws-cli) from 1.25.51 to 1.25.67.
- [Release notes](https://github.com/aws/aws-cli/releases)
- [Changelog](https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst)
- [Commits](aws/aws-cli@1.25.51...1.25.67)

---
updated-dependencies:
- dependency-name: awscli
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
The EKS tests were failing as a result of this upgrade due to the change in the template url
for awscdkawseksKubectlProviderNestedStackawscdkawseksKubectlProviderNestedStackResourceA7AEBA6B
The object key for this asset was changed.
@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/lambda-layer-update branch from 9697f5b to d4c44e9 Compare September 12, 2022 14:39
@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/lambda-layer-update branch from d4c44e9 to abdd62e Compare September 12, 2022 15:06
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: abdd62e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy 🥑

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6b7ad6b into main Sep 12, 2022
@mergify mergify bot deleted the TheRealAmazonKendra/lambda-layer-update branch September 12, 2022 15:56
mackalex pushed a commit to wanjacki/aws-cdk that referenced this pull request Sep 15, 2022
aws#21994)

The EKS and StepFunctions Tasks tests were failing as a result of this upgrade due to the change in the template url
for awscdkawseksKubectlProviderNestedStackawscdkawseksKubectlProviderNestedStackResourceA7AEBA6B
The object key for this asset was changed.

Each of the failing tests have also been updated to use the new integ test construct.

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants