Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make does-not-exist.json actually not exist #20986

Merged
merged 2 commits into from
Jul 4, 2022
Merged

chore: make does-not-exist.json actually not exist #20986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580b013
chore: make `does-not-exist.json` actually not exist
rix0rrr Jul 4, 2022
0196b00
Merge branch 'main' into huijbers/but-it-does-exist
mergify[bot] Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/aws-cdk/does-not-exist.json
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/aws-cdk/test/notices.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,10 @@ describe('cli notices', () => {
expect(debugSpy).not.toHaveBeenCalled();

debugSpy.mockRestore();

if (fs.existsSync('does-not-exist.json')) {
fs.unlinkSync('does-not-exist.json');
}
});

test('retrieved data from the delegate when it is configured to ignore the cache', async () => {
Expand Down