Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make does-not-exist.json actually not exist #20986

Merged
merged 2 commits into from
Jul 4, 2022
Merged

chore: make does-not-exist.json actually not exist #20986

merged 2 commits into from
Jul 4, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 4, 2022

Somehow this file got checked in. Remove it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
chore: make does-not-exist.json actually not exist
580b013 
Somehow this file got checked in. Remove it.
@rix0rrr rix0rrr requested a review from a team July 4, 2022 13:55
@rix0rrr rix0rrr self-assigned this Jul 4, 2022
@rix0rrr rix0rrr marked this pull request as ready for review July 4, 2022 13:55
@gitpod-io
Copy link

gitpod-io bot commented Jul 4, 2022

@github-actions github-actions bot added the p2 label Jul 4, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 4, 2022 13:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 4, 2022
kaizencc
kaizencc approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we gitignore the file also? (I guess removing it altogether does the trick)

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0196b00
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c20e2c4 into main Jul 4, 2022
@mergify mergify bot deleted the huijbers/but-it-does-exist branch July 4, 2022 15:10
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
@rix0rrr @daschaa
chore: make does-not-exist.json actually not exist (aws#20986)
f5c72e4 
Somehow this file got checked in. Remove it.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rix0rrr @aws-cdk-automation @kaizencc