Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): latest AlbController version isn't compatible with the chart version #20826

Merged
merged 7 commits into from
Jul 6, 2022
Merged

fix(eks): latest AlbController version isn't compatible with the chart version #20826

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b362103
fix(aws-eks): Allow ALBC Helm Chart version
adriantaut Jun 22, 2022
cde2e6f
feat(aws-eks): no documentation needed
adriantaut Jun 22, 2022
c389311
Merge branch 'main' into eks_alb_chart_version
adriantaut Jun 22, 2022
5448c68
Merge branch 'main' into eks_alb_chart_version
adriantaut Jul 4, 2022
7bdd27b
Remove option to specify albControllerChartVersion
adriantaut Jul 4, 2022
58fcad9
Merge branch 'main' into eks_alb_chart_version
iliapolo Jul 6, 2022
6445281
Merge branch 'main' into eks_alb_chart_version
adriantaut Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-eks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ From the docs:
> * It satisfies Kubernetes Service resources by provisioning Network Load Balancers.

To deploy the controller on your EKS cluster, configure the `albController` property:

```ts
new eks.Cluster(this, 'HelloEKS', {
version: eks.KubernetesVersion.V1_21,
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-eks/lib/alb-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export class AlbController extends Construct {
// want to expose this since helm here is just an implementation detail
// for installing a specific version of the controller itself.
// https://github.com/aws/eks-charts/blob/v0.0.65/stable/aws-load-balancer-controller/Chart.yaml
version: '1.2.7',
version: '1.4.1',

wait: true,
timeout: Duration.minutes(15),
Expand Down
2 changes: 1 addition & 1 deletion .../test/alb-controller.integ.snapshot/aws-cdk-eks-cluster-alb-controller-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,7 +1477,7 @@
},
"Release": "aws-load-balancer-controller",
"Chart": "aws-load-balancer-controller",
"Version": "1.2.7",
"Version": "1.4.1",
"Wait": true,
"Timeout": "900s",
"Values": {
Expand Down
4 changes: 2 additions & 2 deletions ...ws-eks/test/eks-inference.integ.snapshot/aws-cdk-eks-cluster-inference-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1842,7 +1842,7 @@
},
"Release": "aws-load-balancer-controller",
"Chart": "aws-load-balancer-controller",
"Version": "1.2.7",
"Version": "1.4.1",
"Wait": true,
"Timeout": "900s",
"Values": {
Expand Down Expand Up @@ -2247,4 +2247,4 @@
"Default": "/aws/service/eks/optimized-ami/1.21/amazon-linux-2-gpu/recommended/image_id"
}
}
}
}