Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eks): latest AlbController version isn't compatible with the chart version #20826

Merged
merged 7 commits into from
Jul 6, 2022
Merged

fix(eks): latest AlbController version isn't compatible with the chart version #20826

merged 7 commits into from
Jul 6, 2022

Conversation

adriantaut
Copy link
Contributor

@adriantaut adriantaut commented Jun 22, 2022 •
edited by iliapolo
Loading

Bump the chart version.

Fixes #20764

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 22, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team June 22, 2022 08:41
@github-actions github-actions bot added bug This issue is a bug. p2 labels Jun 22, 2022
@adriantaut adriantaut changed the title feat(aws-eks): Allow ALBC Helm Chart version fix(aws-eks): Allow ALBC Helm Chart version Jun 22, 2022
@adriantaut adriantaut mentioned this pull request Jul 4, 2022
Closed
@iliapolo
Copy link
Contributor

iliapolo commented Jul 6, 2022

@adriantaut The PR body says that you allow the version to be passed - but I don't see that functionality in the code...did you mean something else? I'd actually be in favor of exposing this version.

@iliapolo iliapolo self-assigned this Jul 6, 2022
@iliapolo iliapolo requested review from iliapolo and removed request for a team July 6, 2022 09:24
@iliapolo
Copy link
Contributor

iliapolo commented Jul 6, 2022

@adriantaut The PR body says that you allow the version to be passed - but I don't see that functionality in the code...did you mean something else? I'd actually be in favor of exposing this version.

I'm also happy approving this PR, just wanted to double check

@iliapolo iliapolo changed the title fix(aws-eks): Allow ALBC Helm Chart version fix(eks): Allow ALBC Helm Chart version Jul 6, 2022
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p1 and removed p2 labels Jul 6, 2022
@iliapolo
Copy link
Contributor

iliapolo commented Jul 6, 2022

@adriantaut Scratch my previous comment. I see the change was due to #20764 (comment) 👍

@iliapolo iliapolo changed the title fix(eks): Allow ALBC Helm Chart version fix(eks): latest AlbController version isn't compatible with the chart version Jul 6, 2022
iliapolo
iliapolo previously approved these changes Jul 6, 2022
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed iliapolo’s stale review July 6, 2022 10:02

Pull request has been modified.

@adriantaut
Copy link
Contributor Author

@adriantaut Scratch my previous comment. I see the change was due to #20764 (comment) 👍

cheers, thank you @iliapolo for your approval!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6445281
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 43a0cec into aws:main Jul 6, 2022
iliapolo pushed a commit that referenced this pull request Jul 6, 2022
@adriantaut @iliapolo
fix(eks): latest AlbController version isn't compatible with the ch…
f40662b 
…art version (#20826)

Bump the chart version.

Fixes #20764

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
@adriantaut @daschaa
fix(eks): latest AlbController version isn't compatible with the ch…
46f7c27 
…art version (aws#20826)

Bump the chart version.

Fixes aws#20764

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@adriantaut adriantaut deleted the eks_alb_chart_version branch July 13, 2022 06:58
@adriantaut
Copy link
Contributor Author

@iliapolo aren't the PRs backported to CDKv1 anymore?

@iliapolo
Copy link
Contributor

@adriantaut No. See #19836

@Hazzard17h Hazzard17h mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-eks): AlbController fixed Helm Chart version causing issues
3 participants
@adriantaut @iliapolo @aws-cdk-automation